test/crm
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: update exchange rate fetching logic to include service provider context and improve error handling

Browse Source
This commit is contained in:
Shariq Ansari 2025-07-28 16:20:08 +05:30
parent 23a823f2bb
commit b46d5a4e5e
1 changed files with 31 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
crm/fcrm/doctype/crm_currency_exchange_settings/crm_currency_exchange_settings.py
View File

@ -15,6 +15,8 @@ def get_exchange_rate(from_currency, to_currency, date=None):
if not date: if not date:
date = "latest" date = "latest"
api_used = "frankfurter"
api_endpoint = f"https://api.frankfurter.app/{date}?from={from_currency}&to={to_currency}" api_endpoint = f"https://api.frankfurter.app/{date}?from={from_currency}&to={to_currency}"
res = requests.get(api_endpoint, timeout=5) res = requests.get(api_endpoint, timeout=5)
if res.ok: if res.ok:
@ -24,6 +26,7 @@ def get_exchange_rate(from_currency, to_currency, date=None):
# Fallback to exchangerate.host if Frankfurter API fails # Fallback to exchangerate.host if Frankfurter API fails
ces = frappe.get_single("CRM Currency Exchange Settings") ces = frappe.get_single("CRM Currency Exchange Settings")
if ces and ces.service_provider == "exchangerate.host": if ces and ces.service_provider == "exchangerate.host":
api_used = "exchangerate.host"
if not ces.access_key: if not ces.access_key:
frappe.throw( frappe.throw(
_("Access Key is required for Service Provider: {0}").format( _("Access Key is required for Service Provider: {0}").format(
@ -50,6 +53,32 @@ def get_exchange_rate(from_currency, to_currency, date=None):
frappe.log_error( frappe.log_error(
title="Exchange Rate Fetch Error", title="Exchange Rate Fetch Error",
message=f"Failed to fetch exchange rate from {from_currency} to {to_currency} on {date}", message=f"Failed to fetch exchange rate from {from_currency} to {to_currency} using {api_used} API.",
)
if api_used == "frankfurter":
user = frappe.session.user
is_manager = (
"System Manager" in frappe.get_roles(user)
or "Sales Manager" in frappe.get_roles(user)
or user == "Administrator"
)
if not is_manager:
frappe.throw(
_(
"Ask your manager to set up the Currency Exchange Provider, as default provider does not support currency conversion for {0} to {1}."
).format(from_currency, to_currency)
)
else:
frappe.throw(
_(
"Setup the Currency Exchange Provider as 'exchangerate.host' in settings, as default provider does not support currency conversion for {0} to {1}."
).format(from_currency, to_currency)
)
frappe.throw(
_(
"Failed to fetch exchange rate from {0} to {1} on {2}. Please check your internet connection or try again later."
).format(from_currency, to_currency, date)
) )
return 1.0 # Default exchange rate if API call fails or no rate found