The doc change introduced in #1037 is initially helpful but then internally
inconsistent. It correctly points out that X-Forwarded-For is no longer
used in setting REMOTE_ADDR (c4873681299212d6082cd9902740eef18c2f14f1),
but then confusingly indicates a solution using the X-Forwarded-For header.
The deployment doc provides a full configuration example which includes
proxy headers as set by nginx. What is missing, before this patch, is a
clear suggestion on how to make use of the header in Gunicorn's access
log.
Accordingly, remove the confusing suggestion and replace it with a drop-in
replacement for Gunicorn's default access log format.
- run lint using latest Python 3.7
- updated env list in tox.ini
- added py38-dev
- removed py36-dev
- moved aiohttp to requirements_test.txt
Signed-off-by: Brett Randall <javabrett@gmail.com>
The systemd files recommended in the docs do not work. The socket file disappears after the first request, or after the service is restarted.
This commit updates the systemd files to include the correct settings
If you have two (or more) instances of gunicorn that use `reuse-port`
and bind to single unix socket all work until one of gunicorn will
stopped. Because the first stopped removes unix socket file and other
instances can't longer process requests.
If you have two (or more) instances of gunicorn that use `reuse-port` and bind to single unix socket all work until one of gunicorn will stopped. Because the first stopped removes unix socket file and other instances can't longer process requests.
Some systems report UNIX socket addresses as bytes while others will
report it as a unicode string type. This patch improves socket type
detection code to support both.
Fix#1861
0f527a01f4 added a fix for the case when some modules have the `__file__` attr set to `None`, for the polling reloader. Unfortunately, it missed making the same fix for the inotify reloader.
This change copies that fix into InotifyReloader
The sample as-is was not clear about what file the configuration was to go in.
This sample is to go into nginx.conf, but nginx as of 20180516 has
nginx.conf + conf.f/default.conf. This sample overrides all that into the single
file so being specific is better.