fix: replace with replace all

This commit is contained in:
Safwan Samsudeen 2024-04-14 12:57:16 +05:30
parent e0bcc333ee
commit b42a63c547
2 changed files with 8 additions and 4 deletions

View File

@ -110,13 +110,13 @@ export default {
.sort((a, b) => b.length - a.length) // big string first .sort((a, b) => b.length - a.length) // big string first
.forEach((key) => { .forEach((key) => {
if (str.includes(key)) { if (str.includes(key)) {
str = str.replace(key, `$${formatted_values.length}`); str = str.replaceAll(key, `$${formatted_values.length}`);
formatted_values.push(format_map[key]); formatted_values.push(format_map[key]);
} }
}); });
formatted_values.forEach((value, i) => { formatted_values.forEach((value, i) => {
str = str.replace(`$${i}`, value); str = str.replaceAll(`$${i}`, value);
}); });
return str; return str;

View File

@ -173,7 +173,7 @@ export default class Gantt {
if (task.dependencies) { if (task.dependencies) {
deps = task.dependencies deps = task.dependencies
.split(",") .split(",")
.map((d) => d.trim()) .map((d) => d.trim().replaceAll(' ', '_'))
.filter((d) => d); .filter((d) => d);
} }
task.dependencies = deps; task.dependencies = deps;
@ -183,7 +183,7 @@ export default class Gantt {
if (!task.id) { if (!task.id) {
task.id = generate_id(task); task.id = generate_id(task);
} else if (typeof task.id === 'string') { } else if (typeof task.id === 'string') {
task.id = task.id.replace(' ', '_') task.id = task.id.replaceAll(' ', '_')
} else { } else {
task.id = `${task.id}` task.id = `${task.id}`
} }
@ -953,6 +953,9 @@ export default class Gantt {
if (!($bar_progress && $bar_progress.finaldx)) return; if (!($bar_progress && $bar_progress.finaldx)) return;
$bar_progress.finaldx = 0; $bar_progress.finaldx = 0;
bar = null;
$bar_progress = null;
$bar = null;
bar.progress_changed(); bar.progress_changed();
bar.set_action_completed(); bar.set_action_completed();
}); });
@ -1030,6 +1033,7 @@ export default class Gantt {
} }
get_bar(id) { get_bar(id) {
console.log(id, this.bars)
return this.bars.find((bar) => { return this.bars.find((bar) => {
return bar.task.id === id; return bar.task.id === id;
}); });