From b42a63c547ab25039b55f0562411ea2b477188d4 Mon Sep 17 00:00:00 2001
From: Safwan Samsudeen <safwansamsudeen.c@gmail.com>
Date: Sun, 14 Apr 2024 12:57:16 +0530
Subject: [PATCH] fix: replace with replace all

---
 src/date_utils.js | 4 ++--
 src/index.js      | 8 ++++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/date_utils.js b/src/date_utils.js
index b39d35b..4938bf7 100644
--- a/src/date_utils.js
+++ b/src/date_utils.js
@@ -110,13 +110,13 @@ export default {
       .sort((a, b) => b.length - a.length) // big string first
       .forEach((key) => {
         if (str.includes(key)) {
-          str = str.replace(key, `$${formatted_values.length}`);
+          str = str.replaceAll(key, `$${formatted_values.length}`);
           formatted_values.push(format_map[key]);
         }
       });
 
     formatted_values.forEach((value, i) => {
-      str = str.replace(`$${i}`, value);
+      str = str.replaceAll(`$${i}`, value);
     });
 
     return str;
diff --git a/src/index.js b/src/index.js
index c259e93..875f577 100644
--- a/src/index.js
+++ b/src/index.js
@@ -173,7 +173,7 @@ export default class Gantt {
         if (task.dependencies) {
           deps = task.dependencies
             .split(",")
-            .map((d) => d.trim())
+            .map((d) => d.trim().replaceAll(' ', '_'))
             .filter((d) => d);
         }
         task.dependencies = deps;
@@ -183,7 +183,7 @@ export default class Gantt {
       if (!task.id) {
         task.id = generate_id(task);
       } else if (typeof task.id === 'string') {
-        task.id = task.id.replace(' ', '_')
+        task.id = task.id.replaceAll(' ', '_')
       } else {
         task.id = `${task.id}`
       }
@@ -953,6 +953,9 @@ export default class Gantt {
       if (!($bar_progress && $bar_progress.finaldx)) return;
 
       $bar_progress.finaldx = 0;
+      bar = null;
+      $bar_progress = null;
+      $bar = null;
       bar.progress_changed();
       bar.set_action_completed();
     });
@@ -1030,6 +1033,7 @@ export default class Gantt {
   }
 
   get_bar(id) {
+    console.log(id, this.bars)
     return this.bars.find((bar) => {
       return bar.task.id === id;
     });