jingrow/datatable
1
0
Fork 0
Code Pull Requests Activity

scrollToCell before .focus()

Browse Source 
- .focus() scrolls to cell automatically, which conflicts with how scrollToCell works
- so changed the order
This commit is contained in:
Faris Ansari 2018-02-21 15:04:05 +05:30
parent 62203c79bb
commit 3c4198fc83
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dist/frappe-datatable.cjs.js vendored
View File

@ -1328,6 +1328,8 @@ class CellManager {
return; return;
} }
this.scrollToCell($cell);
this.deactivateEditing(); this.deactivateEditing();
if (!skipClearSelection) { if (!skipClearSelection) {
this.clearSelection(); this.clearSelection();
@ -1344,7 +1346,6 @@ class CellManager {
$cell.focus(); $cell.focus();
this.highlightRowColumnHeader($cell); this.highlightRowColumnHeader($cell);
this.scrollToCell($cell);
} }
highlightRowColumnHeader($cell) { highlightRowColumnHeader($cell) {

3
dist/frappe-datatable.js vendored
View File

@ -1327,6 +1327,8 @@ class CellManager {
return; return;
} }
this.scrollToCell($cell);
this.deactivateEditing(); this.deactivateEditing();
if (!skipClearSelection) { if (!skipClearSelection) {
this.clearSelection(); this.clearSelection();
@ -1343,7 +1345,6 @@ class CellManager {
$cell.focus(); $cell.focus();
this.highlightRowColumnHeader($cell); this.highlightRowColumnHeader($cell);
this.scrollToCell($cell);
} }
highlightRowColumnHeader($cell) { highlightRowColumnHeader($cell) {

3
src/cellmanager.js
View File

@ -174,6 +174,8 @@ export default class CellManager {
return; return;
} }
this.scrollToCell($cell);
this.deactivateEditing(); this.deactivateEditing();
if (!skipClearSelection) { if (!skipClearSelection) {
this.clearSelection(); this.clearSelection();
@ -190,7 +192,6 @@ export default class CellManager {
$cell.focus(); $cell.focus();
this.highlightRowColumnHeader($cell); this.highlightRowColumnHeader($cell);
this.scrollToCell($cell);
} }
highlightRowColumnHeader($cell) { highlightRowColumnHeader($cell) {