From 3c4198fc8354a018c98e37287b946da692a9265d Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Wed, 21 Feb 2018 15:04:05 +0530 Subject: [PATCH] scrollToCell before .focus() - .focus() scrolls to cell automatically, which conflicts with how scrollToCell works - so changed the order --- dist/frappe-datatable.cjs.js | 3 ++- dist/frappe-datatable.js | 3 ++- src/cellmanager.js | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/dist/frappe-datatable.cjs.js b/dist/frappe-datatable.cjs.js index 2cec045..11a346f 100644 --- a/dist/frappe-datatable.cjs.js +++ b/dist/frappe-datatable.cjs.js @@ -1328,6 +1328,8 @@ class CellManager { return; } + this.scrollToCell($cell); + this.deactivateEditing(); if (!skipClearSelection) { this.clearSelection(); @@ -1344,7 +1346,6 @@ class CellManager { $cell.focus(); this.highlightRowColumnHeader($cell); - this.scrollToCell($cell); } highlightRowColumnHeader($cell) { diff --git a/dist/frappe-datatable.js b/dist/frappe-datatable.js index 06837ea..5edabbb 100644 --- a/dist/frappe-datatable.js +++ b/dist/frappe-datatable.js @@ -1327,6 +1327,8 @@ class CellManager { return; } + this.scrollToCell($cell); + this.deactivateEditing(); if (!skipClearSelection) { this.clearSelection(); @@ -1343,7 +1345,6 @@ class CellManager { $cell.focus(); this.highlightRowColumnHeader($cell); - this.scrollToCell($cell); } highlightRowColumnHeader($cell) { diff --git a/src/cellmanager.js b/src/cellmanager.js index 270413d..b03cb31 100644 --- a/src/cellmanager.js +++ b/src/cellmanager.js @@ -174,6 +174,8 @@ export default class CellManager { return; } + this.scrollToCell($cell); + this.deactivateEditing(); if (!skipClearSelection) { this.clearSelection(); @@ -190,7 +192,6 @@ export default class CellManager { $cell.focus(); this.highlightRowColumnHeader($cell); - this.scrollToCell($cell); } highlightRowColumnHeader($cell) {