jingrow/charts
1
0
Fork 0
Code Pull Requests Activity

refactor(charts.js): use switch instead of multiple if else

Browse Source
This commit is contained in:
Moritz 2017-11-01 12:53:09 +01:00 committed by GitHub
parent 4bb44c0914
commit 38a9428059
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/scripts/charts.js
View File

@ -16,18 +16,13 @@ import Heatmap from './charts/Heatmap';
export default class Chart {
constructor(args) {
if(args.type === 'line') {
return new LineChart(arguments[0]);
} else if(args.type === 'bar') {
return new BarChart(arguments[0]);
} else if(args.type === 'scatter') {
return new ScatterChart(arguments[0]);
} else if(args.type === 'percentage') {
return new PercentageChart(arguments[0]);
} else if(args.type === 'heatmap') {
return new Heatmap(arguments[0]);
} else {
return new LineChart(arguments[0]);
switch (args.type) {
case 'line': return new LineChart(arguments[0]);
case 'bar': return new BarChart(arguments[0]);
case 'scatter': return new ScatterChart(arguments[0]);
case 'percentage': return new PercentageChart(arguments[0]);
case 'heatmap': return new Heatmap(arguments[0]);
default: return new LineChart(arguments[0]);
}
}
}
}