From 38a9428059b752d108209e95c89fbd319c8ac121 Mon Sep 17 00:00:00 2001 From: Moritz Date: Wed, 1 Nov 2017 12:53:09 +0100 Subject: [PATCH] refactor(charts.js): use switch instead of multiple if else --- src/scripts/charts.js | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/src/scripts/charts.js b/src/scripts/charts.js index 426c57a..6e1fdf8 100644 --- a/src/scripts/charts.js +++ b/src/scripts/charts.js @@ -16,18 +16,13 @@ import Heatmap from './charts/Heatmap'; export default class Chart { constructor(args) { - if(args.type === 'line') { - return new LineChart(arguments[0]); - } else if(args.type === 'bar') { - return new BarChart(arguments[0]); - } else if(args.type === 'scatter') { - return new ScatterChart(arguments[0]); - } else if(args.type === 'percentage') { - return new PercentageChart(arguments[0]); - } else if(args.type === 'heatmap') { - return new Heatmap(arguments[0]); - } else { - return new LineChart(arguments[0]); + switch (args.type) { + case 'line': return new LineChart(arguments[0]); + case 'bar': return new BarChart(arguments[0]); + case 'scatter': return new ScatterChart(arguments[0]); + case 'percentage': return new PercentageChart(arguments[0]); + case 'heatmap': return new Heatmap(arguments[0]); + default: return new LineChart(arguments[0]); } } -} \ No newline at end of file +}