From 29c7c672edc4d23336f53ac80c835865bf7583b2 Mon Sep 17 00:00:00 2001
From: Ankush Menat <ankushmenat@gmail.com>
Date: Fri, 12 Apr 2024 19:44:01 +0530
Subject: [PATCH] fix: remove redundant guest checks

---
 crm/api/notifications.py                      |  6 ------
 crm/api/session.py                            | 14 +-------------
 crm/api/views.py                              |  3 ---
 crm/fcrm/doctype/crm_call_log/crm_call_log.py |  2 +-
 4 files changed, 2 insertions(+), 23 deletions(-)

diff --git a/crm/api/notifications.py b/crm/api/notifications.py
index bdbe9118..3dde662c 100644
--- a/crm/api/notifications.py
+++ b/crm/api/notifications.py
@@ -4,9 +4,6 @@ from frappe.query_builder import Order
 
 @frappe.whitelist()
 def get_notifications():
-    if frappe.session.user == "Guest":
-        frappe.throw("Authentication failed", exc=frappe.AuthenticationError)
-
     Notification = frappe.qb.DocType("CRM Notification")
     query = (
         frappe.qb.from_(Notification)
@@ -46,9 +43,6 @@ def get_notifications():
 
 @frappe.whitelist()
 def mark_as_read(user=None, comment=None):
-    if frappe.session.user == "Guest":
-        frappe.throw("Authentication failed", exc=frappe.AuthenticationError)
-
     user = user or frappe.session.user
     filters = {"to_user": user, "read": False}
     if comment:
diff --git a/crm/api/session.py b/crm/api/session.py
index c6218317..3902ff7f 100644
--- a/crm/api/session.py
+++ b/crm/api/session.py
@@ -1,11 +1,8 @@
 import frappe
 
 
-@frappe.whitelist(allow_guest=True)
+@frappe.whitelist()
 def get_users():
-	if frappe.session.user == "Guest":
-		frappe.throw("Authentication failed", exc=frappe.AuthenticationError)
-
 	users = frappe.qb.get_query(
 		"User",
 		fields=["name", "email", "enabled", "user_image", "full_name", "user_type"],
@@ -24,9 +21,6 @@ def get_users():
 
 @frappe.whitelist()
 def get_contacts():
-	if frappe.session.user == "Guest":
-		frappe.throw("Authentication failed", exc=frappe.AuthenticationError)
-
 	contacts = frappe.get_all(
 		"Contact",
 		fields=[
@@ -66,9 +60,6 @@ def get_contacts():
 
 @frappe.whitelist()
 def get_lead_contacts():
-	if frappe.session.user == "Guest":
-		frappe.throw("Authentication failed", exc=frappe.AuthenticationError)
-
 	lead_contacts = frappe.get_all(
 		"CRM Lead",
 		fields=[
@@ -88,9 +79,6 @@ def get_lead_contacts():
 
 @frappe.whitelist()
 def get_organizations():
-	if frappe.session.user == "Guest":
-		frappe.throw("Authentication failed", exc=frappe.AuthenticationError)
-
 	organizations = frappe.qb.get_query(
 		"CRM Organization",
 		fields=['*'],
diff --git a/crm/api/views.py b/crm/api/views.py
index 6a95adbf..f70246e1 100644
--- a/crm/api/views.py
+++ b/crm/api/views.py
@@ -4,9 +4,6 @@ from pypika import Criterion
 
 @frappe.whitelist()
 def get_views(doctype):
-	if frappe.session.user == "Guest":
-		frappe.throw("Authentication failed", exc=frappe.AuthenticationError)
-
 	View = frappe.qb.DocType("CRM View Settings")
 	query = (
 		frappe.qb.from_(View)
diff --git a/crm/fcrm/doctype/crm_call_log/crm_call_log.py b/crm/fcrm/doctype/crm_call_log/crm_call_log.py
index 6c646e4c..0147b9ac 100644
--- a/crm/fcrm/doctype/crm_call_log/crm_call_log.py
+++ b/crm/fcrm/doctype/crm_call_log/crm_call_log.py
@@ -93,7 +93,7 @@ def get_call_log(name):
 		if c:
 			return [c.full_name, c.image]
 		return [None, None]
-	
+
 	def get_lead_contact(number):
 		l = frappe.db.get_value("CRM Lead", {"mobile_no": number, "converted": 0}, ["lead_name", "image"], as_dict=True)
 		if l: