From e92c0f6f76db73cedbf831ed9213f4d3cda8dce1 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Wed, 21 Feb 2024 11:56:26 +0530
Subject: [PATCH] fix: changing mobile_no for contact was buggy

---
 .../src/components/Modals/ContactModal.vue    | 19 +++++++++++++------
 frontend/src/pages/Contact.vue                |  8 ++++----
 frontend/src/stores/contacts.js               |  1 +
 3 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/frontend/src/components/Modals/ContactModal.vue b/frontend/src/components/Modals/ContactModal.vue
index 3b7f5cb0..e16c26a3 100644
--- a/frontend/src/components/Modals/ContactModal.vue
+++ b/frontend/src/components/Modals/ContactModal.vue
@@ -79,10 +79,10 @@
                   >
                     <template #default="{ open }">
                       <Button
-                        :label="contact[field.name]"
+                        :label="_contact[field.name]"
                         class="dropdown-button h-8 w-full justify-between truncate rounded border border-gray-300 bg-white px-2.5 py-1.5 text-base placeholder-gray-500 hover:border-gray-400 hover:bg-white hover:shadow-sm focus:border-gray-500 focus:bg-white focus:shadow-sm focus:ring-0 focus-visible:ring-2 focus-visible:ring-gray-400"
                       >
-                        <div class="truncate">{{ contact[field.name] }}</div>
+                        <div class="truncate">{{ _contact[field.name] }}</div>
                         <template #suffix>
                           <FeatherIcon
                             :name="open ? 'chevron-up' : 'chevron-down'"
@@ -345,7 +345,10 @@ const sections = computed(() => {
               component: h(DropdownItem, {
                 value: email.email_id,
                 selected: email.email_id === props.contact.email_id,
-                onClick: () => setAsPrimary('email', email.email_id),
+                onClick: () => {
+                  _contact.value.email_id = email.email_id
+                  setAsPrimary('email', email.email_id)
+                },
               }),
             }
           }),
@@ -375,13 +378,17 @@ const sections = computed(() => {
         {
           label: 'Mobile No.',
           type: props.contact.name ? 'dropdown' : 'data',
-          name: 'mobile_no',
+          name: 'actual_mobile_no',
           options: props.contact?.phone_nos?.map((phone) => {
             return {
               component: h(DropdownItem, {
                 value: phone.phone,
-                selected: phone.phone === props.contact.mobile_no,
-                onClick: () => setAsPrimary('mobile_no', phone.phone),
+                selected: phone.phone === props.contact.actual_mobile_no,
+                onClick: () => {
+                  _contact.value.actual_mobile_no = phone.phone
+                  _contact.value.mobile_no = phone.phone
+                  setAsPrimary('mobile_no', phone.phone)
+                },
               }),
             }
           }),
diff --git a/frontend/src/pages/Contact.vue b/frontend/src/pages/Contact.vue
index 1b9f6c80..096fd096 100644
--- a/frontend/src/pages/Contact.vue
+++ b/frontend/src/pages/Contact.vue
@@ -70,17 +70,17 @@
               >
                 &middot;
               </span>
-              <Tooltip text="Make Call" v-if="contact.mobile_no">
+              <Tooltip text="Make Call" v-if="contact.actual_mobile_no">
                 <div
                   class="flex cursor-pointer items-center gap-1.5"
-                  @click="makeCall(contact.mobile_no)"
+                  @click="makeCall(contact.actual_mobile_no)"
                 >
                   <PhoneIcon class="h-4 w-4" />
-                  <span class="">{{ contact.mobile_no }}</span>
+                  <span class="">{{ contact.actual_mobile_no }}</span>
                 </div>
               </Tooltip>
               <span
-                v-if="contact.mobile_no"
+                v-if="contact.actual_mobile_no"
                 class="text-3xl leading-[0] text-gray-600"
               >
                 &middot;
diff --git a/frontend/src/stores/contacts.js b/frontend/src/stores/contacts.js
index 04b17ffc..06ff23f2 100644
--- a/frontend/src/stores/contacts.js
+++ b/frontend/src/stores/contacts.js
@@ -17,6 +17,7 @@ export const contactsStore = defineStore('crm-contacts', () => {
       for (let contact of contacts) {
         // remove special characters from phone number to make it easier to search
         // also remove spaces but keep + sign at the start
+        contact.actual_mobile_no = contact.mobile_no
         contact.mobile_no = contact.mobile_no?.replace(/[^0-9+]/g, '')
         contactsByPhone[contact.mobile_no] = contact
         contactsByName[contact.name] = contact