From cc1ac48d59b65fc9449f7e87ec238c5f0fea09dd Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Fri, 19 Jan 2024 23:29:44 +0530 Subject: [PATCH] fix: make view public permission fix --- crm/fcrm/doctype/crm_view_settings/crm_view_settings.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crm/fcrm/doctype/crm_view_settings/crm_view_settings.py b/crm/fcrm/doctype/crm_view_settings/crm_view_settings.py index 19e0ab04..2387a9fd 100644 --- a/crm/fcrm/doctype/crm_view_settings/crm_view_settings.py +++ b/crm/fcrm/doctype/crm_view_settings/crm_view_settings.py @@ -65,7 +65,7 @@ def delete(name): @frappe.whitelist() def public(name, value): - if "Sales Manager" not in frappe.get_roles() or frappe.session.user != "Administrator": + if frappe.session.user != "Administrator" and "Sales Manager" not in frappe.get_roles(): frappe.throw("Not permitted", frappe.PermissionError) doc = frappe.get_doc("CRM View Settings", name)