From bee2de6f6f1b55022f73f33087cd4bfe119cd332 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Wed, 21 Aug 2024 16:48:46 +0530
Subject: [PATCH] fix: extracted out view breadcrumb which contain view
 selector

---
 frontend/src/components/ViewBreadcrumbs.vue | 48 +++++++++++++++++++++
 frontend/src/components/ViewControls.vue    |  6 +--
 frontend/src/pages/Leads.vue                | 36 +---------------
 3 files changed, 51 insertions(+), 39 deletions(-)
 create mode 100644 frontend/src/components/ViewBreadcrumbs.vue

diff --git a/frontend/src/components/ViewBreadcrumbs.vue b/frontend/src/components/ViewBreadcrumbs.vue
new file mode 100644
index 00000000..bb167ce2
--- /dev/null
+++ b/frontend/src/components/ViewBreadcrumbs.vue
@@ -0,0 +1,48 @@
+<template>
+  <div class="flex items-center">
+    <router-link
+      :to="{ name: routeName }"
+      class="px-0.5 py-1 text-lg font-medium focus:outline-none focus-visible:ring-2 focus-visible:ring-gray-400 text-gray-600 hover:text-gray-700"
+    >
+      {{ __(routeName) }}
+    </router-link>
+    <span class="mx-0.5 text-base text-gray-500" aria-hidden="true"> / </span>
+    <Dropdown v-if="viewControls" :options="viewControls.viewsDropdownOptions">
+      <template #default="{ open }">
+        <Button
+          variant="ghost"
+          class="text-lg font-medium"
+          :label="__(viewControls.currentView.label)"
+        >
+          <template #prefix>
+            <Icon :icon="viewControls.currentView.icon" class="h-4" />
+          </template>
+          <template #suffix>
+            <FeatherIcon
+              :name="open ? 'chevron-up' : 'chevron-down'"
+              class="h-4 text-gray-800"
+            />
+          </template>
+        </Button>
+      </template>
+    </Dropdown>
+    <Dropdown :options="viewControls.viewActions">
+      <template #default>
+        <Button variant="ghost" icon="more-horizontal" />
+      </template>
+    </Dropdown>
+  </div>
+</template>
+<script setup>
+import Icon from '@/components/Icon.vue'
+import { Dropdown } from 'frappe-ui'
+
+const props = defineProps({
+  routeName: {
+    type: String,
+    required: true,
+  },
+})
+
+const viewControls = defineModel()
+</script>
diff --git a/frontend/src/components/ViewControls.vue b/frontend/src/components/ViewControls.vue
index fa05ef09..77af14d9 100644
--- a/frontend/src/components/ViewControls.vue
+++ b/frontend/src/components/ViewControls.vue
@@ -59,11 +59,6 @@
     </div>
   </div>
   <div v-else class="flex items-center justify-between gap-2 px-5 py-4">
-    <!-- <Dropdown :options="viewActions">
-        <template #default>
-          <Button icon="more-horizontal" />
-        </template>
-      </Dropdown> -->
     <FadedScrollableDiv
       class="flex flex-1 items-center overflow-x-auto -ml-1"
       orientation="horizontal"
@@ -1085,6 +1080,7 @@ defineExpose({
   likeDoc,
   updateKanbanSettings,
   loadMoreKanban,
+  viewActions,
   viewsDropdownOptions,
   currentView,
 })
diff --git a/frontend/src/pages/Leads.vue b/frontend/src/pages/Leads.vue
index 132aa51c..c25cfa45 100644
--- a/frontend/src/pages/Leads.vue
+++ b/frontend/src/pages/Leads.vue
@@ -1,39 +1,7 @@
 <template>
   <LayoutHeader>
     <template #left-header>
-      <div class="flex items-center">
-        <router-link
-          :to="{ name: 'Leads' }"
-          class="px-0.5 py-1 text-lg font-medium focus:outline-none focus-visible:ring-2 focus-visible:ring-gray-400 text-gray-600 hover:text-gray-700"
-        >
-          {{ __('Leads') }}
-        </router-link>
-        <span class="mx-0.5 text-base text-gray-500" aria-hidden="true">
-          /
-        </span>
-        <Dropdown
-          v-if="viewControls"
-          :options="viewControls.viewsDropdownOptions"
-        >
-          <template #default="{ open }">
-            <Button
-              variant="ghost"
-              class="text-lg font-medium"
-              :label="__(viewControls.currentView.label)"
-            >
-              <template #prefix>
-                <Icon :icon="viewControls.currentView.icon" class="h-4" />
-              </template>
-              <template #suffix>
-                <FeatherIcon
-                  :name="open ? 'chevron-up' : 'chevron-down'"
-                  class="h-4 text-gray-800"
-                />
-              </template>
-            </Button>
-          </template>
-        </Dropdown>
-      </div>
+      <ViewBreadcrumbs v-model="viewControls" routeName="Leads" />
     </template>
     <template #right-header>
       <CustomActions
@@ -317,7 +285,7 @@
 </template>
 
 <script setup>
-import Icon from '@/components/Icon.vue'
+import ViewBreadcrumbs from '@/components/ViewBreadcrumbs.vue'
 import MultipleAvatar from '@/components/MultipleAvatar.vue'
 import CustomActions from '@/components/CustomActions.vue'
 import EmailAtIcon from '@/components/Icons/EmailAtIcon.vue'