From 13714dabfd48f2d7bd991d685fb4514f1edb149b Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Mon, 19 Feb 2024 18:45:19 +0530 Subject: [PATCH 1/4] build(deps): bump frappeui to 0.1.31 --- frappe-ui | 2 +- frontend/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe-ui b/frappe-ui index 388c8706..5b17c224 160000 --- a/frappe-ui +++ b/frappe-ui @@ -1 +1 @@ -Subproject commit 388c8706d0f96d918651018ca58d85a56d2bf5cb +Subproject commit 5b17c2242369729b4e9aa31c0c78d3d53676a77f diff --git a/frontend/package.json b/frontend/package.json index e0eb1aae..abb5eb08 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -13,7 +13,7 @@ "@vueuse/core": "^10.3.0", "@vueuse/integrations": "^10.3.0", "feather-icons": "^4.28.0", - "frappe-ui": "^0.1.30", + "frappe-ui": "^0.1.31", "mime": "^4.0.1", "pinia": "^2.0.33", "socket.io-client": "^4.7.2", From 1ba6cb78e196b35b865fe7d0644f89927bb10ff3 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Tue, 20 Feb 2024 15:10:53 +0530 Subject: [PATCH 2/4] fix: added data-name on avatar div --- frontend/src/components/MultipleAvatar.vue | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frontend/src/components/MultipleAvatar.vue b/frontend/src/components/MultipleAvatar.vue index 9cbdd132..adba7bad 100644 --- a/frontend/src/components/MultipleAvatar.vue +++ b/frontend/src/components/MultipleAvatar.vue @@ -24,11 +24,12 @@ :key="avatar.name" > From 486eba41eda3a4735aea3f7a120ccef647c42e00 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Tue, 20 Feb 2024 15:11:50 +0530 Subject: [PATCH 3/4] fix: added & exposed applyFilter method in ViewControls --- frontend/src/components/ViewControls.vue | 33 ++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/frontend/src/components/ViewControls.vue b/frontend/src/components/ViewControls.vue index 41e8333e..4235b30b 100644 --- a/frontend/src/components/ViewControls.vue +++ b/frontend/src/components/ViewControls.vue @@ -536,6 +536,39 @@ function saveView() { showViewModal.value = true } +function applyFilter({ event, idx, column, item }) { + let restrictedFieldtypes = ['Duration', 'Datetime', 'Time'] + if (restrictedFieldtypes.includes(column.type) || idx === 0) return + + event.stopPropagation() + event.preventDefault() + + let filters = { ...list.value.params.filters } + + let value = item.name || item.label || item + + if (value) { + filters[column.key] = value + } else { + delete filters[column.key] + } + + if (column.key == '_assign') { + if (item.length > 1) { + let target = e.target.closest('.user-avatar') + if (target) { + let name = target.getAttribute('data-name') + filters['_assign'] = ['LIKE', `%${name}%`] + } + } else { + filters['_assign'] = ['LIKE', `%${item[0].name}%`] + } + } + updateFilter(filters) +} + +defineExpose({ applyFilter }) + // Watchers watch( () => getView(route.query.view), From 76d21200768bc2f6b4bfe3559ba2eafc8d409a23 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Tue, 20 Feb 2024 15:34:28 +0530 Subject: [PATCH 4/4] fix: apply applyFilter feat in all listviews --- .../components/ListViews/CallLogsListView.vue | 14 ++++++++++--- .../components/ListViews/ContactsListView.vue | 8 +++++-- .../components/ListViews/DealsListView.vue | 21 +++++++++++++++---- .../ListViews/EmailTemplatesListView.vue | 8 +++++-- .../components/ListViews/LeadsListView.vue | 21 +++++++++++++++---- .../ListViews/OrganizationsListView.vue | 8 +++++-- .../components/ListViews/TasksListView.vue | 9 ++++++-- frontend/src/pages/CallLogs.vue | 3 +++ frontend/src/pages/Contacts.vue | 3 +++ frontend/src/pages/Deals.vue | 3 +++ frontend/src/pages/EmailTemplates.vue | 3 +++ frontend/src/pages/Leads.vue | 3 +++ frontend/src/pages/Organizations.vue | 3 +++ frontend/src/pages/Tasks.vue | 3 +++ 14 files changed, 91 insertions(+), 19 deletions(-) diff --git a/frontend/src/components/ListViews/CallLogsListView.vue b/frontend/src/components/ListViews/CallLogsListView.vue index 60757240..1ccb7202 100644 --- a/frontend/src/components/ListViews/CallLogsListView.vue +++ b/frontend/src/components/ListViews/CallLogsListView.vue @@ -18,10 +18,13 @@ class="mx-5" v-for="row in rows" :key="row.name" - v-slot="{ column, item }" + v-slot="{ idx, column, item }" :row="row" > - +
{ if (!organizations.value?.data?.data) return [] diff --git a/frontend/src/pages/Tasks.vue b/frontend/src/pages/Tasks.vue index bc3a601a..8c6cd405 100644 --- a/frontend/src/pages/Tasks.vue +++ b/frontend/src/pages/Tasks.vue @@ -10,6 +10,7 @@
{ if (!tasks.value?.data?.data) return []