From 44bf3d1cf706f7dc58a26f4a957eb6e9bf43ce5c Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Fri, 28 Feb 2025 15:44:10 +0530
Subject: [PATCH] fix: show name quick filter if added and sort based on global
 settings

---
 crm/api/doc.py                           | 22 ++++++++++++++++------
 frontend/src/components/ViewControls.vue |  2 +-
 2 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/crm/api/doc.py b/crm/api/doc.py
index dbdde3e0..9cc5c653 100644
--- a/crm/api/doc.py
+++ b/crm/api/doc.py
@@ -186,22 +186,32 @@ def get_quick_filters(doctype: str, cached: bool = True):
 	if global_settings := frappe.db.exists("CRM Global Settings", {"dt": doctype, "type": "Quick Filters"}):
 		_quick_filters = frappe.db.get_value("CRM Global Settings", global_settings, "json")
 		_quick_filters = json.loads(_quick_filters) or []
-		fields = [field for field in meta.fields if field.fieldname in _quick_filters]
+
+		fields = []
+
+		for filter in _quick_filters:
+			if filter == "name":
+				fields.append({"label": "Name", "fieldname": "name", "fieldtype": "Data"})
+			else:
+				field = next((f for f in meta.fields if f.fieldname == filter), None)
+				if field:
+					fields.append(field)
+
 	else:
 		fields = [field for field in meta.fields if field.in_standard_filter]
 
 	for field in fields:
-		options = field.options
-		if field.fieldtype == "Select" and options and isinstance(options, str):
+		options = field.get("options")
+		if field.get("fieldtype") == "Select" and options and isinstance(options, str):
 			options = options.split("\n")
 			options = [{"label": option, "value": option} for option in options]
 			if not any([not option.get("value") for option in options]):
 				options.insert(0, {"label": "", "value": ""})
 		quick_filters.append(
 			{
-				"label": _(field.label),
-				"fieldname": field.fieldname,
-				"fieldtype": field.fieldtype,
+				"label": _(field.get("label")),
+				"fieldname": field.get("fieldname"),
+				"fieldtype": field.get("fieldtype"),
 				"options": options,
 			}
 		)
diff --git a/frontend/src/components/ViewControls.vue b/frontend/src/components/ViewControls.vue
index 7edbca70..3da088f2 100644
--- a/frontend/src/components/ViewControls.vue
+++ b/frontend/src/components/ViewControls.vue
@@ -729,7 +729,7 @@ const quickFilterOptions = computed(() => {
   if (!options.some((f) => f.fieldname === 'name')) {
     options.push({
       label: __('Name'),
-      fieldname: 'name',
+      value: 'name',
       fieldtype: 'Data',
     })
   }