From 2e577db7cb5e6f9cf7c33a7b966e5e91dbe24784 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Tue, 19 Mar 2024 22:31:20 +0530 Subject: [PATCH] fix: removed unnessary permission check --- .../doctype/crm_service_level_agreement/utils.py | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/crm/fcrm/doctype/crm_service_level_agreement/utils.py b/crm/fcrm/doctype/crm_service_level_agreement/utils.py index 72cbfeef..809dcafe 100644 --- a/crm/fcrm/doctype/crm_service_level_agreement/utils.py +++ b/crm/fcrm/doctype/crm_service_level_agreement/utils.py @@ -5,8 +5,6 @@ from frappe.utils.safe_exec import get_safe_globals from frappe.utils import now_datetime from pypika import Criterion -DOCTYPE = "CRM Service Level Agreement" - def get_sla(doc: Document) -> Document: """ Get Service Level Agreement for `doc` @@ -14,8 +12,7 @@ def get_sla(doc: Document) -> Document: :param doc: Lead/Deal to use :return: Applicable SLA """ - check_permissions(DOCTYPE, None) - SLA = frappe.qb.DocType(DOCTYPE) + SLA = frappe.qb.DocType("CRM Service Level Agreement") Priority = frappe.qb.DocType("CRM Service Level Priority") now = now_datetime() priority = doc.communication_status @@ -50,17 +47,6 @@ def get_sla(doc: Document) -> Document: break return res -def check_permissions(doctype, parent): - user = frappe.session.user - permissions = ("select", "read") - has_select_permission, has_read_permission = [ - frappe.has_permission(doctype, perm, user=user, parent_doctype=parent) - for perm in permissions - ] - - if not has_select_permission and not has_read_permission: - frappe.throw(f"Insufficient Permission for {doctype}", frappe.PermissionError) - def get_context(d: Document) -> dict: """ Get safe context for `safe_eval`