test/jcrm
1
0
Fork 0
forked from test/crm
Code Pull Requests Activity

fix: removed guest access from convert to deal api

Browse Source
This commit is contained in:
Shariq Ansari 2024-03-23 14:33:23 +05:30
parent 9b018c29ea
commit 0f93ccc6e9
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
crm/fcrm/doctype/crm_lead/crm_lead.py
View File

@ -247,6 +247,9 @@ class CRMLead(Document):
if sla: if sla:
sla.apply(self) sla.apply(self)
def convert_to_deal(self):
return convert_to_deal(lead=self.name, doc=self)
@staticmethod @staticmethod
def get_non_filterable_fields(): def get_non_filterable_fields():
return ["converted"] return ["converted"]
@ -317,12 +320,9 @@ class CRMLead(Document):
] ]
return {'columns': columns, 'rows': rows} return {'columns': columns, 'rows': rows}
@frappe.whitelist(allow_guest=True) @frappe.whitelist()
def convert_to_deal(lead, allow_guest=False): def convert_to_deal(lead, doc=None):
if not allow_guest and frappe.session.user == "Guest": if not (doc and doc.flags.get("ignore_permissions")) and not frappe.has_permission("CRM Lead", "write", lead):
frappe.throw(_("Not allowed to convert Lead to Deal"), frappe.AuthenticationError)
if not frappe.has_permission("CRM Lead", "write", lead) and not allow_guest:
frappe.throw(_("Not allowed to convert Lead to Deal"), frappe.PermissionError) frappe.throw(_("Not allowed to convert Lead to Deal"), frappe.PermissionError)
lead = frappe.get_cached_doc("CRM Lead", lead) lead = frappe.get_cached_doc("CRM Lead", lead)