test/crm
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: avoid showing certain fields changes in activity timeline

Browse Source
This commit is contained in:
Shariq Ansari 2023-12-26 16:31:00 +05:30
parent 5454a4f8e5
commit fe320bdb7a
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
crm/api/activities.py
View File

@ -19,6 +19,14 @@ def get_deal_activities(name):
docinfo = frappe.response["docinfo"] docinfo = frappe.response["docinfo"]
deal_meta = frappe.get_meta("CRM Deal") deal_meta = frappe.get_meta("CRM Deal")
deal_fields = {field.fieldname: {"label": field.label, "options": field.options} for field in deal_meta.fields} deal_fields = {field.fieldname: {"label": field.label, "options": field.options} for field in deal_meta.fields}
avoid_fields = [
"lead",
"response_by",
"sla_creation",
"sla",
"first_response_time",
"first_responded_on",
]
doc = frappe.db.get_values("CRM Deal", name, ["creation", "owner", "lead"])[0] doc = frappe.db.get_values("CRM Deal", name, ["creation", "owner", "lead"])[0]
lead = doc[2] lead = doc[2]
@ -48,7 +56,7 @@ def get_deal_activities(name):
if change := data.get("changed")[0]: if change := data.get("changed")[0]:
field = deal_fields.get(change[0], None) field = deal_fields.get(change[0], None)
if not field or change[0] == "lead" or (not change[1] and not change[2]): if not field or change[0] in avoid_fields or (not change[1] and not change[2]):
continue continue
field_label = field.get("label") or change[0] field_label = field.get("label") or change[0]
@ -116,6 +124,14 @@ def get_lead_activities(name):
docinfo = frappe.response["docinfo"] docinfo = frappe.response["docinfo"]
lead_meta = frappe.get_meta("CRM Lead") lead_meta = frappe.get_meta("CRM Lead")
lead_fields = {field.fieldname: {"label": field.label, "options": field.options} for field in lead_meta.fields} lead_fields = {field.fieldname: {"label": field.label, "options": field.options} for field in lead_meta.fields}
avoid_fields = [
"converted",
"response_by",
"sla_creation",
"sla",
"first_response_time",
"first_responded_on",
]
doc = frappe.db.get_values("CRM Lead", name, ["creation", "owner"])[0] doc = frappe.db.get_values("CRM Lead", name, ["creation", "owner"])[0]
activities = [{ activities = [{
@ -136,7 +152,7 @@ def get_lead_activities(name):
if change := data.get("changed")[0]: if change := data.get("changed")[0]:
field = lead_fields.get(change[0], None) field = lead_fields.get(change[0], None)
if not field or change[0] == "converted" or (not change[1] and not change[2]): if not field or change[0] in avoid_fields or (not change[1] and not change[2]):
continue continue
field_label = field.get("label") or change[0] field_label = field.get("label") or change[0]