From e9e0aa357b1b1596f57d8bda0037f36514972169 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Wed, 11 Jun 2025 14:20:11 +0530
Subject: [PATCH] fix: trigger on change on status change

---
 frontend/src/components/Modals/DealModal.vue |  4 ++--
 frontend/src/components/Modals/LeadModal.vue |  4 ++--
 frontend/src/pages/Deal.vue                  | 14 +++++++++++--
 frontend/src/pages/Lead.vue                  | 22 ++++++++++++++------
 frontend/src/pages/MobileDeal.vue            | 14 +++++++++++--
 frontend/src/pages/MobileLead.vue            | 14 +++++++++++--
 frontend/src/stores/statuses.js              | 13 ++++++++----
 7 files changed, 65 insertions(+), 20 deletions(-)

diff --git a/frontend/src/components/Modals/DealModal.vue b/frontend/src/components/Modals/DealModal.vue
index 1c516407..e4ce7419 100644
--- a/frontend/src/components/Modals/DealModal.vue
+++ b/frontend/src/components/Modals/DealModal.vue
@@ -94,7 +94,7 @@ const show = defineModel()
 const router = useRouter()
 const error = ref(null)
 
-const { document: deal } = useDocument('CRM Deal')
+const { document: deal, triggerOnChange } = useDocument('CRM Deal')
 
 const hasOrganizationSections = ref(true)
 const hasContactSections = ref(true)
@@ -164,7 +164,7 @@ const tabs = createResource({
 })
 
 const dealStatuses = computed(() => {
-  let statuses = statusOptions('deal')
+  let statuses = statusOptions('deal', null, [], triggerOnChange)
   if (!deal.doc.status) {
     deal.doc.status = statuses[0].value
   }
diff --git a/frontend/src/components/Modals/LeadModal.vue b/frontend/src/components/Modals/LeadModal.vue
index bf1461d1..1976ad3c 100644
--- a/frontend/src/components/Modals/LeadModal.vue
+++ b/frontend/src/components/Modals/LeadModal.vue
@@ -70,10 +70,10 @@ const router = useRouter()
 const error = ref(null)
 const isLeadCreating = ref(false)
 
-const { document: lead } = useDocument('CRM Lead')
+const { document: lead, triggerOnChange } = useDocument('CRM Lead')
 
 const leadStatuses = computed(() => {
-  let statuses = statusOptions('lead')
+  let statuses = statusOptions('lead', null, [], triggerOnChange)
   if (!lead.doc.status) {
     lead.doc.status = statuses?.[0]?.value
   }
diff --git a/frontend/src/pages/Deal.vue b/frontend/src/pages/Deal.vue
index e3d09fa7..34e06141 100644
--- a/frontend/src/pages/Deal.vue
+++ b/frontend/src/pages/Deal.vue
@@ -23,7 +23,14 @@
       />
       <Dropdown
         v-if="document.doc"
-        :options="statusOptions('deal', document, deal.data._customStatuses)"
+        :options="
+          statusOptions(
+            'deal',
+            document,
+            deal.data._customStatuses,
+            triggerOnChange,
+          )
+        "
       >
         <template #default="{ open }">
           <Button :label="document.doc.status">
@@ -726,7 +733,10 @@ function openEmailBox() {
   activities.value.emailBox.show = true
 }
 
-const { assignees, document } = useDocument('CRM Deal', props.dealId)
+const { assignees, document, triggerOnChange } = useDocument(
+  'CRM Deal',
+  props.dealId,
+)
 
 function reloadAssignees(data) {
   if (data?.hasOwnProperty('deal_owner')) {
diff --git a/frontend/src/pages/Lead.vue b/frontend/src/pages/Lead.vue
index 6cd0befc..17612e19 100644
--- a/frontend/src/pages/Lead.vue
+++ b/frontend/src/pages/Lead.vue
@@ -23,7 +23,14 @@
       />
       <Dropdown
         v-if="document.doc"
-        :options="statusOptions('lead', document, lead.data._customStatuses)"
+        :options="
+          statusOptions(
+            'lead',
+            document,
+            lead.data._customStatuses,
+            triggerOnChange,
+          )
+        "
       >
         <template #default="{ open }">
           <Button :label="document.doc.status">
@@ -344,7 +351,12 @@ import SidePanelLayout from '@/components/SidePanelLayout.vue'
 import FieldLayout from '@/components/FieldLayout/FieldLayout.vue'
 import SLASection from '@/components/SLASection.vue'
 import CustomActions from '@/components/CustomActions.vue'
-import { openWebsite, setupCustomizations, copyToClipboard, validateIsImageFile } from '@/utils'
+import {
+  openWebsite,
+  setupCustomizations,
+  copyToClipboard,
+  validateIsImageFile,
+} from '@/utils'
 import { showQuickEntryModal, quickEntryProps } from '@/composables/modals'
 import { getView } from '@/utils/view'
 import { getSettings } from '@/stores/settings'
@@ -605,10 +617,8 @@ const existingOrganizationChecked = ref(false)
 const existingContact = ref('')
 const existingOrganization = ref('')
 
-const { triggerConvertToDeal, assignees, document } = useDocument(
-  'CRM Lead',
-  props.leadId,
-)
+const { triggerConvertToDeal, triggerOnChange, assignees, document } =
+  useDocument('CRM Lead', props.leadId)
 
 async function convertToDeal() {
   if (existingContactChecked.value && !existingContact.value) {
diff --git a/frontend/src/pages/MobileDeal.vue b/frontend/src/pages/MobileDeal.vue
index 71995d88..1920266f 100644
--- a/frontend/src/pages/MobileDeal.vue
+++ b/frontend/src/pages/MobileDeal.vue
@@ -11,7 +11,14 @@
       <div class="absolute right-0">
         <Dropdown
           v-if="document.doc"
-          :options="statusOptions('deal', document, deal.data._customStatuses)"
+          :options="
+            statusOptions(
+              'deal',
+              document,
+              deal.data._customStatuses,
+              triggerOnChange,
+            )
+          "
         >
           <template #default="{ open }">
             <Button :label="document.doc.status">
@@ -612,7 +619,10 @@ async function deleteDeal(name) {
   router.push({ name: 'Deals' })
 }
 
-const { assignees, document } = useDocument('CRM Deal', props.dealId)
+const { assignees, document, triggerOnChange } = useDocument(
+  'CRM Deal',
+  props.dealId,
+)
 
 function reloadAssignees(data) {
   if (data?.hasOwnProperty('deal_owner')) {
diff --git a/frontend/src/pages/MobileLead.vue b/frontend/src/pages/MobileLead.vue
index da7574dd..21743037 100644
--- a/frontend/src/pages/MobileLead.vue
+++ b/frontend/src/pages/MobileLead.vue
@@ -11,7 +11,14 @@
       <div class="absolute right-0">
         <Dropdown
           v-if="document.doc"
-          :options="statusOptions('lead', document, lead.data._customStatuses)"
+          :options="
+            statusOptions(
+              'lead',
+              document,
+              lead.data._customStatuses,
+              triggerOnChange,
+            )
+          "
         >
           <template #default="{ open }">
             <Button :label="document.doc.status">
@@ -461,7 +468,10 @@ async function convertToDeal() {
   }
 }
 
-const { assignees, document } = useDocument('CRM Lead', props.leadId)
+const { assignees, document, triggerOnChange } = useDocument(
+  'CRM Lead',
+  props.leadId,
+)
 
 function reloadAssignees(data) {
   if (data?.hasOwnProperty('lead_owner')) {
diff --git a/frontend/src/stores/statuses.js b/frontend/src/stores/statuses.js
index 9a63da26..0bcdbf3d 100644
--- a/frontend/src/stores/statuses.js
+++ b/frontend/src/stores/statuses.js
@@ -77,7 +77,12 @@ export const statusesStore = defineStore('crm-statuses', () => {
     return communicationStatuses[name]
   }
 
-  function statusOptions(doctype, document, statuses = []) {
+  function statusOptions(
+    doctype,
+    document,
+    statuses = [],
+    triggerOnChange = null,
+  ) {
     let statusesByName =
       doctype == 'deal' ? dealStatusesByName : leadStatusesByName
 
@@ -85,7 +90,7 @@ export const statusesStore = defineStore('crm-statuses', () => {
       statuses = document.statuses
     }
 
-    if (statuses.length) {
+    if (statuses?.length) {
       statusesByName = statuses.reduce((acc, status) => {
         acc[status] = statusesByName[status]
         return acc
@@ -98,10 +103,10 @@ export const statusesStore = defineStore('crm-statuses', () => {
         label: statusesByName[status]?.name,
         value: statusesByName[status]?.name,
         icon: () => h(IndicatorIcon, { class: statusesByName[status]?.color }),
-        onClick: () => {
+        onClick: async () => {
           capture('status_changed', { doctype, status })
           if (document) {
-            document.doc.status = statusesByName[status]?.name
+            await triggerOnChange?.('status', statusesByName[status]?.name)
             document.save.submit()
           }
         },