From e9694140d15c00c382c9ff89d2f636b860534512 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Tue, 7 Nov 2023 14:06:35 +0530
Subject: [PATCH] fix: hide converted or lead set activity which happen behind
 the scene

---
 crm/api/activities.py | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/crm/api/activities.py b/crm/api/activities.py
index c761a211..4f81074a 100644
--- a/crm/api/activities.py
+++ b/crm/api/activities.py
@@ -47,6 +47,10 @@ def get_deal_activities(name):
 
 		if change := data.get("changed")[0]:
 			field_label, field_option = next(((f.label, f.options) for f in deal_fields_meta if f.fieldname == change[0]), None)
+
+			if field_label == "Lead" or (not change[1] and not change[2]):
+				continue
+
 			activity_type = "changed"
 			data = {
 				"field": change[0],
@@ -54,8 +58,7 @@ def get_deal_activities(name):
 				"old_value": change[1],
 				"value": change[2],
 			}
-			if not change[1] and not change[2]:
-				continue
+
 			if not change[1] and change[2]:
 				activity_type = "added"
 				data = {
@@ -129,6 +132,10 @@ def get_lead_activities(name):
 
 		if change := data.get("changed")[0]:
 			field_label, field_option = next(((f.label, f.options) for f in lead_fields_meta if f.fieldname == change[0]), None)
+
+			if field_label == "Converted" or (not change[1] and not change[2]):
+				continue
+
 			activity_type = "changed"
 			data = {
 				"field": change[0],
@@ -136,8 +143,7 @@ def get_lead_activities(name):
 				"old_value": change[1],
 				"value": change[2],
 			}
-			if not change[1] and not change[2]:
-				continue
+
 			if not change[1] and change[2]:
 				activity_type = "added"
 				data = {