From df91cfb8175f4e9b0da53d41686dc5c14b48e16b Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Tue, 18 Mar 2025 14:12:48 +0530
Subject: [PATCH] fix: removed api to update onboarding status

---
 crm/api/onboarding.py                          | 18 ------------------
 frontend/src/components/Layouts/AppSidebar.vue |  2 +-
 frontend/src/pages/Deal.vue                    |  4 ++--
 3 files changed, 3 insertions(+), 21 deletions(-)

diff --git a/crm/api/onboarding.py b/crm/api/onboarding.py
index 088000e3..00d27b07 100644
--- a/crm/api/onboarding.py
+++ b/crm/api/onboarding.py
@@ -1,24 +1,6 @@
-import json
-
 import frappe
 
 
-@frappe.whitelist()
-def update_user_onboarding_status(steps: str):
-	steps = json.loads(steps)
-
-	# get the current onboarding status
-	onboarding_status = frappe.db.get_value("User", frappe.session.user, "onboarding_status")
-	onboarding_status = frappe.parse_json(onboarding_status)
-
-	# update the onboarding status
-	onboarding_status["frappe_crm_onboarding_status"] = steps
-
-	frappe.db.set_value(
-		"User", frappe.session.user, "onboarding_status", json.dumps(onboarding_status), update_modified=False
-	)
-
-
 @frappe.whitelist()
 def get_first_lead():
 	lead = frappe.get_all(
diff --git a/frontend/src/components/Layouts/AppSidebar.vue b/frontend/src/components/Layouts/AppSidebar.vue
index 1174698d..56df60a0 100644
--- a/frontend/src/components/Layouts/AppSidebar.vue
+++ b/frontend/src/components/Layouts/AppSidebar.vue
@@ -296,7 +296,7 @@ const steps = reactive([
     name: 'create_first_lead',
     title: 'Create your first lead',
     icon: markRaw(LeadsIcon),
-    completed: true,
+    completed: false,
     onClick: () => {
       minimize.value = true
       router.push({ name: 'Leads' })
diff --git a/frontend/src/pages/Deal.vue b/frontend/src/pages/Deal.vue
index 88e2dc90..96d84c15 100644
--- a/frontend/src/pages/Deal.vue
+++ b/frontend/src/pages/Deal.vue
@@ -340,7 +340,6 @@ import {
   Breadcrumbs,
   call,
   usePageMeta,
-  isOnboardingStepsCompleted,
   useOnboarding,
 } from 'frappe-ui'
 import { ref, computed, h, onMounted, onBeforeUnmount } from 'vue'
@@ -352,7 +351,8 @@ const { $dialog, $socket, makeCall } = globalStore()
 const { statusOptions, getDealStatus } = statusesStore()
 const { doctypeMeta } = getMeta('CRM Deal')
 
-const { updateOnboardingStep } = useOnboarding('frappecrm')
+const { updateOnboardingStep, isOnboardingStepsCompleted } =
+  useOnboarding('frappecrm')
 
 const route = useRoute()
 const router = useRouter()