From ce1c07ed34bb86365c073c720c1cb5625bba83d1 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Thu, 27 Jul 2023 12:08:08 +0530
Subject: [PATCH] fix: pass list title and plural/singular label to listview

---
 frontend/src/components/ListView.vue | 8 ++++----
 frontend/src/pages/Contacts.vue      | 8 ++++++--
 frontend/src/pages/Deals.vue         | 8 ++++++--
 frontend/src/pages/Inbox.vue         | 8 ++++++--
 frontend/src/pages/Leads.vue         | 8 ++++++--
 5 files changed, 28 insertions(+), 12 deletions(-)

diff --git a/frontend/src/components/ListView.vue b/frontend/src/components/ListView.vue
index 23f7acaa..4ee6d939 100644
--- a/frontend/src/components/ListView.vue
+++ b/frontend/src/components/ListView.vue
@@ -1,7 +1,7 @@
 <template>
   <div id="header" class="flex justify-between items-center px-5 py-4">
     <div class="left flex space-x-2">
-      <h1 class="font-semibold text-xl">{{ title }}s</h1>
+      <h1 class="font-semibold text-xl">{{ list.title }}</h1>
     </div>
     <div class="right flex space-x-2">
       <Button variant="solid" label="Create">
@@ -161,8 +161,8 @@ import IndicatorIcon from './Icons/IndicatorIcon.vue'
 import { reactive, ref, computed } from 'vue'
 
 const props = defineProps({
-  title: {
-    type: String,
+  list: {
+    type: Object,
     required: true,
   },
   columns: {
@@ -239,7 +239,7 @@ function getValue(value) {
 
 let selections = reactive(new Set())
 let selectedText = computed(() => {
-  let title = selections.size === 1 ? props.title : `${props.title}s`
+  let title = selections.size === 1 ? props.list.singular_label : props.list.plural_label
   return `${selections.size} ${title} selected`
 })
 
diff --git a/frontend/src/pages/Contacts.vue b/frontend/src/pages/Contacts.vue
index b0fdf138..a911a4fd 100644
--- a/frontend/src/pages/Contacts.vue
+++ b/frontend/src/pages/Contacts.vue
@@ -1,5 +1,5 @@
 <template>
-  <ListView :title="title" :columns="columns" :rows="rows" row-key="name" />
+  <ListView :list="list_details" :columns="columns" :rows="rows" row-key="name" />
 </template>
 
 <script setup>
@@ -7,7 +7,11 @@ import ListView from '../components/ListView.vue'
 import { computed } from 'vue'
 import { createListResource } from 'frappe-ui'
 
-const title = 'Contact'
+const list_details = {
+  title: 'Contacts',
+  plural_label: 'Contacts',
+  singular_label: 'Contact',
+}
 
 const contacts = createListResource({
   type: 'list',
diff --git a/frontend/src/pages/Deals.vue b/frontend/src/pages/Deals.vue
index 21e8472b..600d8580 100644
--- a/frontend/src/pages/Deals.vue
+++ b/frontend/src/pages/Deals.vue
@@ -1,9 +1,13 @@
 <template>
-  <ListView :title="title"/>
+  <ListView :list="list_details"/>
 </template>
 
 <script setup>
 import ListView from '../components/ListView.vue';
 
-let title = 'Deals'
+const list_details = {
+  title: 'Deals',
+  plural_label: 'Deals',
+  singular_label: 'Deal',
+}
 </script>
diff --git a/frontend/src/pages/Inbox.vue b/frontend/src/pages/Inbox.vue
index 74dbc426..c3ad11ea 100644
--- a/frontend/src/pages/Inbox.vue
+++ b/frontend/src/pages/Inbox.vue
@@ -1,9 +1,13 @@
 <template>
-  <ListView :title="title"/>
+  <ListView :list="list_details"/>
 </template>
 
 <script setup>
 import ListView from '../components/ListView.vue';
 
-let title = 'Inbox'
+const list_details = {
+  title: 'Inbox',
+  plural_label: 'Emails',
+  singular_label: 'Email',
+}
 </script>
diff --git a/frontend/src/pages/Leads.vue b/frontend/src/pages/Leads.vue
index 7b6f2a3e..10123ddd 100644
--- a/frontend/src/pages/Leads.vue
+++ b/frontend/src/pages/Leads.vue
@@ -1,5 +1,5 @@
 <template>
-  <ListView :title="title" :columns="columns" :rows="rows" row-key="name" />
+  <ListView :list="list_details" :columns="columns" :rows="rows" row-key="name" />
 </template>
 
 <script setup>
@@ -8,7 +8,11 @@ import { computed } from 'vue'
 import { createListResource } from 'frappe-ui'
 import { usersStore } from '../stores/users'
 
-const title = 'Lead'
+const list_details = {
+  title: 'Leads',
+  plural_label: 'Leads',
+  singular_label: 'Lead',
+}
 const { getUser } = usersStore()
 
 const leads = createListResource({