From cbf00e29ac1e67557b80f3966cb9b7729edd0ce3 Mon Sep 17 00:00:00 2001
From: Pratik <badhepd@gmail.com>
Date: Fri, 11 Apr 2025 18:09:15 +0530
Subject: [PATCH] refactor: make function names clearer

---
 frontend/src/components/ListViews/CallLogsListView.vue      | 2 +-
 frontend/src/components/ListViews/ContactsListView.vue      | 2 +-
 frontend/src/components/ListViews/DealsListView.vue         | 2 +-
 .../src/components/ListViews/EmailTemplatesListView.vue     | 2 +-
 frontend/src/components/ListViews/LeadsListView.vue         | 2 +-
 frontend/src/components/ListViews/OrganizationsListView.vue | 2 +-
 frontend/src/components/ListViews/TasksListView.vue         | 2 +-
 frontend/src/components/ViewControls.vue                    | 6 +++---
 frontend/src/pages/CallLogs.vue                             | 2 +-
 frontend/src/pages/Contacts.vue                             | 2 +-
 frontend/src/pages/Deals.vue                                | 2 +-
 frontend/src/pages/EmailTemplates.vue                       | 2 +-
 frontend/src/pages/Leads.vue                                | 2 +-
 frontend/src/pages/Organizations.vue                        | 2 +-
 frontend/src/pages/Tasks.vue                                | 2 +-
 15 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/frontend/src/components/ListViews/CallLogsListView.vue b/frontend/src/components/ListViews/CallLogsListView.vue
index 11c7e754..73d80e2c 100644
--- a/frontend/src/components/ListViews/CallLogsListView.vue
+++ b/frontend/src/components/ListViews/CallLogsListView.vue
@@ -10,7 +10,7 @@
     }"
     row-key="name"
     v-bind="$attrs"
-    @update:selections="$emit('selectionsChanged', Array.from($event || []))"
+    @update:selections="(selections) => emit('selectionsChanged', selections)"
   >
     <ListHeader
       class="sm:mx-5 mx-3"
diff --git a/frontend/src/components/ListViews/ContactsListView.vue b/frontend/src/components/ListViews/ContactsListView.vue
index 99a205fe..36a21daa 100644
--- a/frontend/src/components/ListViews/ContactsListView.vue
+++ b/frontend/src/components/ListViews/ContactsListView.vue
@@ -14,7 +14,7 @@
       resizeColumn: options.resizeColumn,
     }"
     row-key="name"
-    @update:selections="$emit('selectionsChanged', Array.from($event || []))"
+    @update:selections="(selections) => emit('selectionsChanged', selections)"
   >
     <ListHeader
       class="mx-3 sm:mx-5"
diff --git a/frontend/src/components/ListViews/DealsListView.vue b/frontend/src/components/ListViews/DealsListView.vue
index 8820a00d..9cc2ba57 100644
--- a/frontend/src/components/ListViews/DealsListView.vue
+++ b/frontend/src/components/ListViews/DealsListView.vue
@@ -14,7 +14,7 @@
       resizeColumn: options.resizeColumn,
     }"
     row-key="name"
-    @update:selections="$emit('selectionsChanged', Array.from($event || []))"
+    @update:selections="(selections) => emit('selectionsChanged', selections)"
   >
     <ListHeader
       class="sm:mx-5 mx-3"
diff --git a/frontend/src/components/ListViews/EmailTemplatesListView.vue b/frontend/src/components/ListViews/EmailTemplatesListView.vue
index a2834ba2..3a642a13 100644
--- a/frontend/src/components/ListViews/EmailTemplatesListView.vue
+++ b/frontend/src/components/ListViews/EmailTemplatesListView.vue
@@ -9,7 +9,7 @@
       resizeColumn: options.resizeColumn,
     }"
     row-key="name"
-    @update:selections="$emit('selectionsChanged', Array.from($event || []))"
+    @update:selections="(selections) => emit('selectionsChanged', selections)"
   >
     <ListHeader
       class="sm:mx-5 mx-3"
diff --git a/frontend/src/components/ListViews/LeadsListView.vue b/frontend/src/components/ListViews/LeadsListView.vue
index f09f12b6..401094ef 100644
--- a/frontend/src/components/ListViews/LeadsListView.vue
+++ b/frontend/src/components/ListViews/LeadsListView.vue
@@ -14,7 +14,7 @@
       resizeColumn: options.resizeColumn,
     }"
     row-key="name"
-    @update:selections="$emit('selectionsChanged', Array.from($event || []))"
+    @update:selections="(selections) => emit('selectionsChanged', selections)"
   >
     <ListHeader
       class="sm:mx-5 mx-3"
diff --git a/frontend/src/components/ListViews/OrganizationsListView.vue b/frontend/src/components/ListViews/OrganizationsListView.vue
index b99e628b..7884ba3d 100644
--- a/frontend/src/components/ListViews/OrganizationsListView.vue
+++ b/frontend/src/components/ListViews/OrganizationsListView.vue
@@ -13,7 +13,7 @@
       resizeColumn: options.resizeColumn,
     }"
     row-key="name"
-    @update:selections="$emit('selectionsChanged', Array.from($event || []))"
+    @update:selections="(selections) => emit('selectionsChanged', selections)"
   >
     <ListHeader
       class="sm:mx-5 mx-3"
diff --git a/frontend/src/components/ListViews/TasksListView.vue b/frontend/src/components/ListViews/TasksListView.vue
index 0be065f1..71550f55 100644
--- a/frontend/src/components/ListViews/TasksListView.vue
+++ b/frontend/src/components/ListViews/TasksListView.vue
@@ -9,7 +9,7 @@
       resizeColumn: options.resizeColumn,
     }"
     row-key="name"
-    @update:selections="$emit('selectionsChanged', Array.from($event || []))"
+    @update:selections="(selections) => emit('selectionsChanged', selections)"
   >
     <ListHeader
       class="mx-3 sm:mx-5"
diff --git a/frontend/src/components/ViewControls.vue b/frontend/src/components/ViewControls.vue
index a4a9b5bf..64350421 100644
--- a/frontend/src/components/ViewControls.vue
+++ b/frontend/src/components/ViewControls.vue
@@ -547,8 +547,8 @@ const export_type = ref('Excel')
 const export_all = ref(false)
 const selectedRows = ref([])
 
-function handleSelectionsChange(selections) {
-  selectedRows.value = selections
+function updateSelections(selections) {
+  selectedRows.value = Array.from(selections)
 }
 
 async function exportRows() {
@@ -1349,7 +1349,7 @@ defineExpose({
   viewActions,
   viewsDropdownOptions,
   currentView,
-  handleSelectionsChange,
+  updateSelections,
 })
 
 // Watchers
diff --git a/frontend/src/pages/CallLogs.vue b/frontend/src/pages/CallLogs.vue
index f3bc54a2..c39c0019 100644
--- a/frontend/src/pages/CallLogs.vue
+++ b/frontend/src/pages/CallLogs.vue
@@ -42,7 +42,7 @@
     @applyLikeFilter="(data) => viewControls.applyLikeFilter(data)"
     @likeDoc="(data) => viewControls.likeDoc(data)"
     @selectionsChanged="
-      (selections) => viewControls.handleSelectionsChange(selections)
+      (selections) => viewControls.updateSelections(selections)
     "
   />
   <div
diff --git a/frontend/src/pages/Contacts.vue b/frontend/src/pages/Contacts.vue
index a73c1736..905a00b5 100644
--- a/frontend/src/pages/Contacts.vue
+++ b/frontend/src/pages/Contacts.vue
@@ -45,7 +45,7 @@
     @applyLikeFilter="(data) => viewControls.applyLikeFilter(data)"
     @likeDoc="(data) => viewControls.likeDoc(data)"
     @selectionsChanged="
-      (selections) => viewControls.handleSelectionsChange(selections)
+      (selections) => viewControls.updateSelections(selections)
     "
   />
   <div
diff --git a/frontend/src/pages/Deals.vue b/frontend/src/pages/Deals.vue
index 830d9454..9da55bad 100644
--- a/frontend/src/pages/Deals.vue
+++ b/frontend/src/pages/Deals.vue
@@ -224,7 +224,7 @@
     @applyLikeFilter="(data) => viewControls.applyLikeFilter(data)"
     @likeDoc="(data) => viewControls.likeDoc(data)"
     @selectionsChanged="
-      (selections) => viewControls.handleSelectionsChange(selections)
+      (selections) => viewControls.updateSelections(selections)
     "
   />
   <div v-else-if="deals.data" class="flex h-full items-center justify-center">
diff --git a/frontend/src/pages/EmailTemplates.vue b/frontend/src/pages/EmailTemplates.vue
index 0193b676..ebede473 100644
--- a/frontend/src/pages/EmailTemplates.vue
+++ b/frontend/src/pages/EmailTemplates.vue
@@ -46,7 +46,7 @@
     @applyLikeFilter="(data) => viewControls.applyLikeFilter(data)"
     @likeDoc="(data) => viewControls.likeDoc(data)"
     @selectionsChanged="
-      (selections) => viewControls.handleSelectionsChange(selections)
+      (selections) => viewControls.updateSelections(selections)
     "
   />
   <div
diff --git a/frontend/src/pages/Leads.vue b/frontend/src/pages/Leads.vue
index e1eb5972..d1141c92 100644
--- a/frontend/src/pages/Leads.vue
+++ b/frontend/src/pages/Leads.vue
@@ -250,7 +250,7 @@
     @applyLikeFilter="(data) => viewControls.applyLikeFilter(data)"
     @likeDoc="(data) => viewControls.likeDoc(data)"
     @selectionsChanged="
-      (selections) => viewControls.handleSelectionsChange(selections)
+      (selections) => viewControls.updateSelections(selections)
     "
   />
   <div v-else-if="leads.data" class="flex h-full items-center justify-center">
diff --git a/frontend/src/pages/Organizations.vue b/frontend/src/pages/Organizations.vue
index 622b8939..442f98c8 100644
--- a/frontend/src/pages/Organizations.vue
+++ b/frontend/src/pages/Organizations.vue
@@ -45,7 +45,7 @@
     @applyLikeFilter="(data) => viewControls.applyLikeFilter(data)"
     @likeDoc="(data) => viewControls.likeDoc(data)"
     @selectionsChanged="
-      (selections) => viewControls.handleSelectionsChange(selections)
+      (selections) => viewControls.updateSelections(selections)
     "
   />
   <div
diff --git a/frontend/src/pages/Tasks.vue b/frontend/src/pages/Tasks.vue
index 9b4ede94..f73e1804 100644
--- a/frontend/src/pages/Tasks.vue
+++ b/frontend/src/pages/Tasks.vue
@@ -173,7 +173,7 @@
     @applyLikeFilter="(data) => viewControls.applyLikeFilter(data)"
     @likeDoc="(data) => viewControls.likeDoc(data)"
     @selectionsChanged="
-      (selections) => viewControls.handleSelectionsChange(selections)
+      (selections) => viewControls.updateSelections(selections)
     "
   />
   <div v-else-if="tasks.data" class="flex h-full items-center justify-center">