test/crm
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use markRaw for reactive Icon

Browse Source
This commit is contained in:
Shariq Ansari 2024-06-03 18:51:45 +05:30
parent 70913c8ae4
commit c70be13ed3
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
frontend/src/components/ViewControls.vue
View File

@ -264,7 +264,7 @@ import { viewsStore } from '@/stores/views'
import { usersStore } from '@/stores/users' import { usersStore } from '@/stores/users'
import { isEmoji } from '@/utils' import { isEmoji } from '@/utils'
import { createResource, Dropdown, call, FeatherIcon } from 'frappe-ui' import { createResource, Dropdown, call, FeatherIcon } from 'frappe-ui'
import { computed, ref, onMounted, watch, h } from 'vue' import { computed, ref, onMounted, watch, h, markRaw } from 'vue'
import { useRouter, useRoute } from 'vue-router' import { useRouter, useRoute } from 'vue-router'
import { useDebounceFn } from '@vueuse/core' import { useDebounceFn } from '@vueuse/core'
import { isMobileView } from '@/stores/settings' import { isMobileView } from '@/stores/settings'
@ -314,7 +314,7 @@ function getViewType() {
}, },
group_by: { group_by: {
label: __('Group By View'), label: __('Group By View'),
icon: DetailsIcon, icon: markRaw(DetailsIcon),
}, },
} }
@ -495,7 +495,7 @@ if (allowedViews.includes('list')) {
if (allowedViews.includes('group_by')) { if (allowedViews.includes('group_by')) {
defaultViews.push({ defaultViews.push({
label: __(props.options?.defaultViewName) || __('Group By View'), label: __(props.options?.defaultViewName) || __('Group By View'),
icon: h(DetailsIcon, { class: 'size-4' }), icon: markRaw(DetailsIcon),
onClick() { onClick() {
viewUpdated.value = false viewUpdated.value = false
router.push({ name: route.name, params: { viewType: 'group_by' } }) router.push({ name: route.name, params: { viewType: 'group_by' } })
@ -507,7 +507,7 @@ function getIcon(icon, type) {
if (isEmoji(icon)) { if (isEmoji(icon)) {
return h('div', icon) return h('div', icon)
} else if (!icon && type === 'group_by') { } else if (!icon && type === 'group_by') {
return DetailsIcon return markRaw(DetailsIcon)
} }
return icon || 'list' return icon || 'list'
} }
@ -812,8 +812,9 @@ const viewModalObj = ref({})
function duplicateView() { function duplicateView() {
let label = let label =
__(getView(route.query.view, route.params.viewType, props.doctype)?.label) || __(
getViewType().label getView(route.query.view, route.params.viewType, props.doctype)?.label
) || getViewType().label
view.value.name = '' view.value.name = ''
view.value.label = label + __(' (New)') view.value.label = label + __(' (New)')
viewModalObj.value = view.value viewModalObj.value = view.value