From b757a0170aeae4c86f77e9c17018db6474cc503f Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Wed, 15 Jan 2025 19:36:19 +0530 Subject: [PATCH] fix: hide border if hide_border is set --- .../doctype/crm_exotel_settings/crm_exotel_settings.json | 8 +++++--- crm/fcrm/doctype/twilio_settings/twilio_settings.json | 8 +++++--- frontend/src/components/Settings/SettingsPage.vue | 1 + frontend/src/components/Settings/TelephonySettings.vue | 2 ++ 4 files changed, 13 insertions(+), 6 deletions(-) diff --git a/crm/fcrm/doctype/crm_exotel_settings/crm_exotel_settings.json b/crm/fcrm/doctype/crm_exotel_settings/crm_exotel_settings.json index 3ddcc440..98382626 100644 --- a/crm/fcrm/doctype/crm_exotel_settings/crm_exotel_settings.json +++ b/crm/fcrm/doctype/crm_exotel_settings/crm_exotel_settings.json @@ -24,7 +24,8 @@ }, { "fieldname": "section_break_kfez", - "fieldtype": "Section Break" + "fieldtype": "Section Break", + "hide_border": 1 }, { "depends_on": "enabled", @@ -36,7 +37,8 @@ { "depends_on": "enabled", "fieldname": "section_break_iuct", - "fieldtype": "Section Break" + "fieldtype": "Section Break", + "hide_border": 1 }, { "fieldname": "column_break_hyen", @@ -73,7 +75,7 @@ "index_web_pages_for_search": 1, "issingle": 1, "links": [], - "modified": "2025-01-15 19:14:25.568485", + "modified": "2025-01-15 19:31:00.310049", "modified_by": "Administrator", "module": "FCRM", "name": "CRM Exotel Settings", diff --git a/crm/fcrm/doctype/twilio_settings/twilio_settings.json b/crm/fcrm/doctype/twilio_settings/twilio_settings.json index 36ae7b04..17e92cfb 100644 --- a/crm/fcrm/doctype/twilio_settings/twilio_settings.json +++ b/crm/fcrm/doctype/twilio_settings/twilio_settings.json @@ -83,7 +83,8 @@ }, { "fieldname": "section_break_malx", - "fieldtype": "Section Break" + "fieldtype": "Section Break", + "hide_border": 1 }, { "default": "0", @@ -93,7 +94,8 @@ }, { "fieldname": "section_break_eklq", - "fieldtype": "Section Break" + "fieldtype": "Section Break", + "hide_border": 1 }, { "fieldname": "column_break_yqvr", @@ -103,7 +105,7 @@ "index_web_pages_for_search": 1, "issingle": 1, "links": [], - "modified": "2025-01-15 19:15:14.687909", + "modified": "2025-01-15 19:35:13.406254", "modified_by": "Administrator", "module": "FCRM", "name": "Twilio Settings", diff --git a/frontend/src/components/Settings/SettingsPage.vue b/frontend/src/components/Settings/SettingsPage.vue index b50f35da..39d6a95a 100644 --- a/frontend/src/components/Settings/SettingsPage.vue +++ b/frontend/src/components/Settings/SettingsPage.vue @@ -131,6 +131,7 @@ const tabs = computed(() => { _sections.push({ label: field.label, name: field.fieldname, + hideBorder: field.hide_border, columns: [{ name: 'column_' + getRandom(), fields: [] }], }) } else if (field.fieldtype === 'Column Break') { diff --git a/frontend/src/components/Settings/TelephonySettings.vue b/frontend/src/components/Settings/TelephonySettings.vue index 1a842c9b..2aeb4698 100644 --- a/frontend/src/components/Settings/TelephonySettings.vue +++ b/frontend/src/components/Settings/TelephonySettings.vue @@ -190,6 +190,7 @@ const twilioTabs = computed(() => { _sections.push({ label: field.label, name: field.fieldname, + hideBorder: field.hide_border, columns: [{ name: 'column_' + getRandom(), fields: [] }], }) } else if (field.fieldtype === 'Column Break') { @@ -241,6 +242,7 @@ const exotelTabs = computed(() => { _sections.push({ label: field.label, name: field.fieldname, + hideBorder: field.hide_border, columns: [{ name: 'column_' + getRandom(), fields: [] }], }) } else if (field.fieldtype === 'Column Break') {