From b5dc2c73ab705b3cf5c1123b75e089fbfa2297cb Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Thu, 15 May 2025 01:15:25 +0530
Subject: [PATCH] fix: remove updateField event from various components

(cherry picked from commit baf344a6976b61a2c62a4cc2e60bf159f546ac49)
(cherry picked from commit 454dbd06cc39bbf93e955d0b6e462641c9c07d8d)
---
 frontend/src/components/Modals/SidePanelModal.vue |  2 +-
 frontend/src/components/SidePanelLayout.vue       | 15 ++++++++++++---
 frontend/src/pages/Contact.vue                    |  1 -
 frontend/src/pages/Deal.vue                       |  1 -
 frontend/src/pages/Lead.vue                       |  1 -
 frontend/src/pages/MobileContact.vue              |  1 -
 frontend/src/pages/MobileDeal.vue                 |  1 -
 frontend/src/pages/MobileLead.vue                 |  1 -
 frontend/src/pages/MobileOrganization.vue         |  1 -
 frontend/src/pages/Organization.vue               |  1 -
 10 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/frontend/src/components/Modals/SidePanelModal.vue b/frontend/src/components/Modals/SidePanelModal.vue
index d352b44f..800f9262 100644
--- a/frontend/src/components/Modals/SidePanelModal.vue
+++ b/frontend/src/components/Modals/SidePanelModal.vue
@@ -38,9 +38,9 @@
           />
           <div v-if="preview" class="flex flex-1 flex-col border rounded">
             <SidePanelLayout
-              v-model="data"
               :sections="tabs.data[0].sections"
               :doctype="_doctype"
+              docname=""
               :preview="true"
               v-slot="{ section }"
             >
diff --git a/frontend/src/components/SidePanelLayout.vue b/frontend/src/components/SidePanelLayout.vue
index c01607bf..9272c656 100644
--- a/frontend/src/components/SidePanelLayout.vue
+++ b/frontend/src/components/SidePanelLayout.vue
@@ -1,6 +1,6 @@
 <template>
   <div
-    v-if="!document.get.loading"
+    v-if="!document.get?.loading"
     class="sections flex flex-col overflow-y-auto"
   >
     <template v-for="(section, i) in _sections" :key="section.name">
@@ -412,11 +412,18 @@ const { getFormattedPercent, getFormattedFloat, getFormattedCurrency } =
 
 const { isManager, getUser } = usersStore()
 
-const emit = defineEmits(['update', 'reload'])
+const emit = defineEmits(['reload'])
 
 const showSidePanelModal = ref(false)
 
-const { document, triggerOnChange } = useDocument(props.doctype, props.docname)
+let document = { doc: {} }
+let triggerOnChange
+
+if (props.docname) {
+  let d = useDocument(props.doctype, props.docname)
+  document = d.document
+  triggerOnChange = d.triggerOnChange
+}
 
 const _sections = computed(() => {
   if (!props.sections?.length) return []
@@ -470,6 +477,8 @@ function parsedField(field) {
 }
 
 async function fieldChange(value, df) {
+  if (props.preview) return
+
   document.doc[df.fieldname] = value
 
   await triggerOnChange(df.fieldname)
diff --git a/frontend/src/pages/Contact.vue b/frontend/src/pages/Contact.vue
index e9fb75bb..42deaa90 100644
--- a/frontend/src/pages/Contact.vue
+++ b/frontend/src/pages/Contact.vue
@@ -124,7 +124,6 @@
           :sections="sections.data"
           doctype="Contact"
           :docname="contact.data.name"
-          @update="updateField"
           @reload="sections.reload"
         />
       </div>
diff --git a/frontend/src/pages/Deal.vue b/frontend/src/pages/Deal.vue
index ad159f0e..9693d545 100644
--- a/frontend/src/pages/Deal.vue
+++ b/frontend/src/pages/Deal.vue
@@ -133,7 +133,6 @@
           :addContact="addContact"
           doctype="CRM Deal"
           :docname="deal.data.name"
-          @update="updateField"
           @reload="sections.reload"
         >
           <template #actions="{ section }">
diff --git a/frontend/src/pages/Lead.vue b/frontend/src/pages/Lead.vue
index 8e68756e..502aff25 100644
--- a/frontend/src/pages/Lead.vue
+++ b/frontend/src/pages/Lead.vue
@@ -185,7 +185,6 @@
           :sections="sections.data"
           doctype="CRM Lead"
           :docname="lead.data.name"
-          @update="updateField"
           @reload="sections.reload"
         />
       </div>
diff --git a/frontend/src/pages/MobileContact.vue b/frontend/src/pages/MobileContact.vue
index 95c6aa4f..de28df96 100644
--- a/frontend/src/pages/MobileContact.vue
+++ b/frontend/src/pages/MobileContact.vue
@@ -133,7 +133,6 @@
               :sections="sections.data"
               doctype="Contact"
               :docname="contact.data.name"
-              @update="updateField"
               @reload="sections.reload"
             />
           </div>
diff --git a/frontend/src/pages/MobileDeal.vue b/frontend/src/pages/MobileDeal.vue
index d03c55cf..c793760f 100644
--- a/frontend/src/pages/MobileDeal.vue
+++ b/frontend/src/pages/MobileDeal.vue
@@ -65,7 +65,6 @@
               :sections="sections.data"
               doctype="CRM Deal"
               :docname="deal.data.name"
-              @update="updateField"
               @reload="sections.reload"
             >
               <template #actions="{ section }">
diff --git a/frontend/src/pages/MobileLead.vue b/frontend/src/pages/MobileLead.vue
index 301f2a2e..55a7a5f2 100644
--- a/frontend/src/pages/MobileLead.vue
+++ b/frontend/src/pages/MobileLead.vue
@@ -70,7 +70,6 @@
               :sections="sections.data"
               doctype="CRM Lead"
               :docname="lead.data.name"
-              @update="updateField"
               @reload="sections.reload"
             />
           </div>
diff --git a/frontend/src/pages/MobileOrganization.vue b/frontend/src/pages/MobileOrganization.vue
index accd3831..b68ac14d 100644
--- a/frontend/src/pages/MobileOrganization.vue
+++ b/frontend/src/pages/MobileOrganization.vue
@@ -115,7 +115,6 @@
               :sections="sections.data"
               doctype="CRM Organization"
               :docname="organization.doc.name"
-              @update="updateField"
               @reload="sections.reload"
             />
           </div>
diff --git a/frontend/src/pages/Organization.vue b/frontend/src/pages/Organization.vue
index 111857fd..a8c04de7 100644
--- a/frontend/src/pages/Organization.vue
+++ b/frontend/src/pages/Organization.vue
@@ -109,7 +109,6 @@
           :sections="sections.data"
           doctype="CRM Organization"
           :docname="organization.doc.name"
-          @update="updateField"
           @reload="sections.reload"
         />
       </div>