From b1bfeca712a27311e6c929dc24ec7e354dae8176 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Tue, 17 Sep 2024 11:20:10 +0530
Subject: [PATCH] fix: extend last section if have space below

---
 frontend/src/components/SectionFields.vue           | 7 ++++++-
 frontend/src/components/Settings/SidePanelModal.vue | 6 +++++-
 frontend/src/pages/Deal.vue                         | 1 +
 frontend/src/pages/Lead.vue                         | 1 +
 frontend/src/pages/MobileDeal.vue                   | 1 +
 frontend/src/pages/MobileLead.vue                   | 1 +
 6 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/SectionFields.vue b/frontend/src/components/SectionFields.vue
index 80a07229..1483d8dd 100644
--- a/frontend/src/components/SectionFields.vue
+++ b/frontend/src/components/SectionFields.vue
@@ -1,6 +1,7 @@
 <template>
   <FadedScrollableDiv
-    class="flex max-h-[300px] flex-col gap-1.5 overflow-y-auto"
+    class="flex flex-col gap-1.5 overflow-y-auto"
+    :class="[isLastSection ? '' : 'max-h-[300px]']"
   >
     <div
       v-for="field in _fields"
@@ -124,6 +125,10 @@ const props = defineProps({
     type: Object,
     required: true,
   },
+  isLastSection: {
+    type: Boolean,
+    default: false,
+  },
 })
 
 const { getUser } = usersStore()
diff --git a/frontend/src/components/Settings/SidePanelModal.vue b/frontend/src/components/Settings/SidePanelModal.vue
index 401d71cb..0e3665ad 100644
--- a/frontend/src/components/Settings/SidePanelModal.vue
+++ b/frontend/src/components/Settings/SidePanelModal.vue
@@ -43,7 +43,11 @@
               :class="{ 'border-b': i !== sections.data.length - 1 }"
             >
               <Section :is-opened="section.opened" :label="section.label">
-                <SectionFields :fields="section.fields" v-model="data" />
+                <SectionFields
+                  :fields="section.fields"
+                  :isLastSection="i == section.data.length - 1"
+                  v-model="data"
+                />
               </Section>
             </div>
           </div>
diff --git a/frontend/src/pages/Deal.vue b/frontend/src/pages/Deal.vue
index 892b4a41..687d0fc8 100644
--- a/frontend/src/pages/Deal.vue
+++ b/frontend/src/pages/Deal.vue
@@ -161,6 +161,7 @@
               <SectionFields
                 v-if="section.fields"
                 :fields="section.fields"
+                :isLastSection="i == fieldsLayout.data.length - 1"
                 v-model="deal.data"
                 @update="updateField"
               />
diff --git a/frontend/src/pages/Lead.vue b/frontend/src/pages/Lead.vue
index 7b15b562..4929b43f 100644
--- a/frontend/src/pages/Lead.vue
+++ b/frontend/src/pages/Lead.vue
@@ -176,6 +176,7 @@
             <Section :is-opened="section.opened" :label="section.label">
               <SectionFields
                 :fields="section.fields"
+                :isLastSection="i == fieldsLayout.data.length - 1"
                 v-model="lead.data"
                 @update="updateField"
               />
diff --git a/frontend/src/pages/MobileDeal.vue b/frontend/src/pages/MobileDeal.vue
index 03a5b7c2..7c635993 100644
--- a/frontend/src/pages/MobileDeal.vue
+++ b/frontend/src/pages/MobileDeal.vue
@@ -101,6 +101,7 @@
                 <SectionFields
                   v-if="section.fields"
                   :fields="section.fields"
+                  :isLastSection="i == fieldsLayout.data.length - 1"
                   v-model="deal.data"
                   @update="updateField"
                 />
diff --git a/frontend/src/pages/MobileLead.vue b/frontend/src/pages/MobileLead.vue
index a2a480c7..b5e132e8 100644
--- a/frontend/src/pages/MobileLead.vue
+++ b/frontend/src/pages/MobileLead.vue
@@ -77,6 +77,7 @@
               <Section :is-opened="section.opened" :label="section.label">
                 <SectionFields
                   :fields="section.fields"
+                  :isLastSection="i == fieldsLayout.data.length - 1"
                   v-model="lead.data"
                   @update="updateField"
                 />