test/crm
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #689 from shariquerik/double-action

Browse Source 
fix: button inside tooltip is triggered twice
This commit is contained in:
Shariq Ansari 2025-03-22 14:43:42 +05:30 committed by GitHub
commit b13d099820
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 141 additions and 107 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/components/Activities/AttachmentArea.vue
View File

@ -43,6 +43,7 @@
attachment.is_private ? __('Make public') : __('Make private')
"
>
<div>
<Button
class="!size-5"
@click.stop="
@ -54,14 +55,17 @@
class="size-3 text-ink-gray-7"
/>
</Button>
</div>
</Tooltip>
<Tooltip :text="__('Delete attachment')">
<div>
<Button
class="!size-5"
@click.stop="() => deleteAttachment(attachment.name)"
>
<FeatherIcon name="trash-2" class="size-3 text-ink-gray-7" />
</Button>
</div>
</Tooltip>
</div>
</div>

2
frontend/src/components/Activities/TaskArea.vue
View File

@ -42,9 +42,11 @@
@click.stop
>
<Tooltip :text="__('Change Status')">
<div>
<Button variant="ghosted" class="hover:bg-surface-gray-4">
<TaskStatusIcon :status="task.status" />
</Button>
</div>
</Tooltip>
</Dropdown>
<Dropdown

7
frontend/src/components/Modals/AssignmentModal.vue
View File

@ -52,10 +52,8 @@
v-for="assignee in assignees"
:key="assignee.name"
>
<Button
:label="getUser(assignee.name).full_name"
theme="gray"
>
<div>
<Button :label="getUser(assignee.name).full_name" theme="gray">
<template #prefix>
<UserAvatar :user="assignee.name" size="sm" />
</template>
@ -68,6 +66,7 @@
/>
</template>
</Button>
</div>
</Tooltip>
</div>
<ErrorMessage class="mt-2" v-if="error" :message="__(error)" />

2
frontend/src/components/Settings/InviteMemberPage.vue
View File

@ -51,6 +51,7 @@
</div>
<div>
<Tooltip text="Delete Invitation">
<div>
<Button
icon="x"
variant="ghost"
@ -60,6 +61,7 @@
"
@click="pendingInvitations.delete.submit(user.name)"
/>
</div>
</Tooltip>
</div>
</li>

15
frontend/src/components/ViewBreadcrumbs.vue
View File

@ -2,11 +2,22 @@
<div class="flex items-center">
<router-link
:to="{ name: routeName }"
class="px-0.5 py-1 text-lg font-medium focus:outline-none focus-visible:ring-2 focus-visible:ring-outline-gray-3 text-ink-gray-5 hover:text-ink-gray-7"
class="px-0.5 py-1 text-lg font-medium focus:outline-none focus-visible:ring-2 focus-visible:ring-outline-gray-3"
:class="[
viewControls
? 'text-ink-gray-5 hover:text-ink-gray-7'
: 'text-ink-gray-7',
]"
>
{{ __(routeName) }}
</router-link>
<span class="mx-0.5 text-base text-ink-gray-4" aria-hidden="true"> / </span>
<span
v-if="viewControls"
class="mx-0.5 text-base text-ink-gray-4"
aria-hidden="true"
>
/
</span>
<Dropdown v-if="viewControls" :options="viewControls.viewsDropdownOptions">
<template #default="{ open }">
<Button

8
frontend/src/pages/Deal.vue
View File

@ -75,11 +75,14 @@
</Tooltip>
<div class="flex gap-1.5">
<Tooltip v-if="callEnabled" :text="__('Make a call')">
<div>
<Button class="h-7 w-7" @click="triggerCall">
<PhoneIcon class="h-4 w-4" />
</Button>
</div>
</Tooltip>
<Tooltip :text="__('Send an email')">
<div>
<Button class="h-7 w-7">
<Email2Icon
class="h-4 w-4"
@ -90,8 +93,10 @@
"
/>
</Button>
</div>
</Tooltip>
<Tooltip :text="__('Go to website')">
<div>
<Button class="h-7 w-7">
<LinkIcon
class="h-4 w-4"
@ -102,11 +107,14 @@
"
/>
</Button>
</div>
</Tooltip>
<Tooltip :text="__('Attach a file')">
<div>
<Button class="size-7" @click="showFilesUploader = true">
<AttachmentIcon class="size-4" />
</Button>
</div>
</Tooltip>
</div>
</div>

8
frontend/src/pages/Lead.vue
View File

@ -117,6 +117,7 @@
</Tooltip>
<div class="flex gap-1.5">
<Tooltip v-if="callEnabled" :text="__('Make a call')">
<div>
<Button
class="h-7 w-7"
@click="
@ -128,8 +129,10 @@
>
<PhoneIcon class="h-4 w-4" />
</Button>
</div>
</Tooltip>
<Tooltip :text="__('Send an email')">
<div>
<Button class="h-7 w-7">
<Email2Icon
class="h-4 w-4"
@ -140,8 +143,10 @@
"
/>
</Button>
</div>
</Tooltip>
<Tooltip :text="__('Go to website')">
<div>
<Button class="h-7 w-7">
<LinkIcon
class="h-4 w-4"
@ -152,11 +157,14 @@
"
/>
</Button>
</div>
</Tooltip>
<Tooltip :text="__('Attach a file')">
<div>
<Button class="h-7 w-7" @click="showFilesUploader = true">
<AttachmentIcon class="h-4 w-4" />
</Button>
</div>
</Tooltip>
</div>
<ErrorMessage :message="__(error)" />