From 42153e740ef0ead3da6152459d751403f1ff3ccd Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Wed, 19 Jun 2024 11:30:41 +0530 Subject: [PATCH 01/23] fix: drag fields from one section to another --- frontend/src/components/Settings/SidebarLayoutBuilder.vue | 1 + frontend/src/pages/Deal.vue | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/frontend/src/components/Settings/SidebarLayoutBuilder.vue b/frontend/src/components/Settings/SidebarLayoutBuilder.vue index 643bea61..a95ab9f2 100644 --- a/frontend/src/components/Settings/SidebarLayoutBuilder.vue +++ b/frontend/src/components/Settings/SidebarLayoutBuilder.vue @@ -42,6 +42,7 @@
{ - let contactSection = fieldsLayout.data.find( + let contactSection = fieldsLayout.data?.find( (section) => section.name == 'contacts_section', ) if (!contactSection) return From 2a253a1d69e550ac5e86138dc0e23b7dd6616312 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Wed, 19 Jun 2024 13:33:32 +0530 Subject: [PATCH 02/23] fix: dirty not working correctly --- .../src/components/Settings/FieldsLayout.vue | 66 +++++++++++-------- 1 file changed, 40 insertions(+), 26 deletions(-) diff --git a/frontend/src/components/Settings/FieldsLayout.vue b/frontend/src/components/Settings/FieldsLayout.vue index 9f6879c7..0858cae0 100644 --- a/frontend/src/components/Settings/FieldsLayout.vue +++ b/frontend/src/components/Settings/FieldsLayout.vue @@ -16,6 +16,7 @@ v-model="doctype" :label="__('DocType')" :options="['CRM Lead', 'CRM Deal']" + @change="reload" />
@@ -25,18 +26,16 @@ variant="solid" @click="saveChanges" /> -
-
+
@@ -47,48 +46,63 @@ From 756b24038ae79d7f37b9c0c91fa9ae2ef90440d2 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Wed, 19 Jun 2024 13:39:58 +0530 Subject: [PATCH 03/23] fix: added + icon in Add Section button --- frontend/src/components/Settings/SidebarLayoutBuilder.vue | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/frontend/src/components/Settings/SidebarLayoutBuilder.vue b/frontend/src/components/Settings/SidebarLayoutBuilder.vue index a95ab9f2..184fb0f8 100644 --- a/frontend/src/components/Settings/SidebarLayoutBuilder.vue +++ b/frontend/src/components/Settings/SidebarLayoutBuilder.vue @@ -112,9 +112,13 @@ variant="outline" :label="__('Add Section')" @click=" - sections.push({ label: 'New Section', opened: true, fields: [] }) + sections.push({ label: __('New Section'), opened: true, fields: [] }) " - /> + > + +
From 30532fb1c3291748d2c6d148c9789bb4075cf573 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Wed, 19 Jun 2024 13:55:24 +0530 Subject: [PATCH 04/23] fix: rearrange settings items --- .../src/components/Settings/SettingsModal.vue | 124 +++++++++--------- 1 file changed, 64 insertions(+), 60 deletions(-) diff --git a/frontend/src/components/Settings/SettingsModal.vue b/frontend/src/components/Settings/SettingsModal.vue index af45481f..a7b78ae2 100644 --- a/frontend/src/components/Settings/SettingsModal.vue +++ b/frontend/src/components/Settings/SettingsModal.vue @@ -3,42 +3,31 @@ - + diff --git a/frontend/src/components/Settings/QuickEntryLayoutBuilder.vue b/frontend/src/components/Settings/QuickEntryLayoutBuilder.vue new file mode 100644 index 00000000..0353f60e --- /dev/null +++ b/frontend/src/components/Settings/QuickEntryLayoutBuilder.vue @@ -0,0 +1,33 @@ + + From ce0ebb03a7ad5379bd34c6d3ca1086a504f245e9 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Wed, 19 Jun 2024 16:39:31 +0530 Subject: [PATCH 08/23] fix: added draggable fields layout with sections --- .../components/Settings/QuickEntryLayout.vue | 62 ++++-- .../Settings/QuickEntryLayoutBuilder.vue | 195 ++++++++++++++++-- 2 files changed, 220 insertions(+), 37 deletions(-) diff --git a/frontend/src/components/Settings/QuickEntryLayout.vue b/frontend/src/components/Settings/QuickEntryLayout.vue index 9fae4596..da43525d 100644 --- a/frontend/src/components/Settings/QuickEntryLayout.vue +++ b/frontend/src/components/Settings/QuickEntryLayout.vue @@ -1,15 +1,15 @@ diff --git a/frontend/src/components/Settings/QuickEntryLayoutBuilder.vue b/frontend/src/components/Settings/QuickEntryLayoutBuilder.vue index 0353f60e..828e9cab 100644 --- a/frontend/src/components/Settings/QuickEntryLayoutBuilder.vue +++ b/frontend/src/components/Settings/QuickEntryLayoutBuilder.vue @@ -1,33 +1,190 @@ From fb8dfb55d6fb2b7b7e0e2bdcc2c69d225aa95218 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Wed, 19 Jun 2024 17:05:41 +0530 Subject: [PATCH 09/23] fix: added/remove column and added all options in dropdown --- .../Settings/QuickEntryLayoutBuilder.vue | 71 +++++++++++++------ .../Settings/SidebarLayoutBuilder.vue | 13 +++- 2 files changed, 60 insertions(+), 24 deletions(-) diff --git a/frontend/src/components/Settings/QuickEntryLayoutBuilder.vue b/frontend/src/components/Settings/QuickEntryLayoutBuilder.vue index 828e9cab..3467101c 100644 --- a/frontend/src/components/Settings/QuickEntryLayoutBuilder.vue +++ b/frontend/src/components/Settings/QuickEntryLayoutBuilder.vue @@ -1,6 +1,6 @@ diff --git a/frontend/src/pages/Contact.vue b/frontend/src/pages/Contact.vue index bcc0f766..02bb60e6 100644 --- a/frontend/src/pages/Contact.vue +++ b/frontend/src/pages/Contact.vue @@ -357,7 +357,10 @@ function getDealRowObject(deal) { label: deal.organization, logo: getOrganization(deal.organization)?.organization_logo, }, - annual_revenue: formatNumberIntoCurrency(deal.annual_revenue), + annual_revenue: formatNumberIntoCurrency( + deal.annual_revenue, + deal.currency, + ), status: { label: deal.status, color: getDealStatus(deal.status)?.iconColorClass, diff --git a/frontend/src/pages/Deals.vue b/frontend/src/pages/Deals.vue index 0aba6daa..2debed3f 100644 --- a/frontend/src/pages/Deals.vue +++ b/frontend/src/pages/Deals.vue @@ -109,7 +109,7 @@ const rows = computed(() => { if (!deals.value?.data.group_by_field?.name) return [] return getGroupedByRows( deals.value?.data.data, - deals.value?.data.group_by_field + deals.value?.data.group_by_field, ) } else { return parseRows(deals.value?.data.data) @@ -158,7 +158,10 @@ function parseRows(rows) { logo: getOrganization(deal.organization)?.organization_logo, } } else if (row == 'annual_revenue') { - _rows[row] = formatNumberIntoCurrency(deal.annual_revenue) + _rows[row] = formatNumberIntoCurrency( + deal.annual_revenue, + deal.currency, + ) } else if (row == 'status') { _rows[row] = { label: deal.status, @@ -171,8 +174,8 @@ function parseRows(rows) { deal.sla_status == 'Failed' ? 'red' : deal.sla_status == 'Fulfilled' - ? 'green' - : 'orange' + ? 'green' + : 'orange' if (value == 'First Response Due') { value = __(timeAgo(deal.response_by)) tooltipText = dateFormat(deal.response_by, dateTooltipFormat) @@ -207,7 +210,7 @@ function parseRows(rows) { } } else if ( ['first_response_time', 'first_responded_on', 'response_by'].includes( - row + row, ) ) { let field = row == 'response_by' ? 'response_by' : 'first_responded_on' diff --git a/frontend/src/pages/Organization.vue b/frontend/src/pages/Organization.vue index 89f3c2b8..96f9e473 100644 --- a/frontend/src/pages/Organization.vue +++ b/frontend/src/pages/Organization.vue @@ -104,7 +104,12 @@ class="flex items-center gap-1.5" > - {{ formatNumberIntoCurrency(organization.doc.annual_revenue) }} + {{ + formatNumberIntoCurrency( + organization.doc.annual_revenue, + organization.doc.currency, + ) + }} { return organizations.value?.data?.data?.find( - (organization) => organization.name === route.params.organizationId + (organization) => organization.name === route.params.organizationId, ) }) @@ -124,7 +124,10 @@ const rows = computed(() => { } else if (row === 'website') { _rows[row] = website(organization.website) } else if (row === 'annual_revenue') { - _rows[row] = formatNumberIntoCurrency(organization.annual_revenue) + _rows[row] = formatNumberIntoCurrency( + organization.annual_revenue, + organization.currency, + ) } else if (['modified', 'creation'].includes(row)) { _rows[row] = { label: dateFormat(organization[row], dateTooltipFormat),