From 97edbf6ca081e377da5dfe7dbce1e5b21b25d87d Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Mon, 6 Nov 2023 17:51:26 +0530
Subject: [PATCH] fix: only show link icon if value exist

---
 frontend/src/pages/Contact.vue | 2 +-
 frontend/src/pages/Deal.vue    | 2 +-
 frontend/src/pages/Lead.vue    | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/frontend/src/pages/Contact.vue b/frontend/src/pages/Contact.vue
index 871fd14c..1c19f654 100644
--- a/frontend/src/pages/Contact.vue
+++ b/frontend/src/pages/Contact.vue
@@ -122,7 +122,7 @@
               />
             </div>
             <ExternalLinkIcon
-              v-if="field.type === 'link' && field.link"
+              v-if="field.type === 'link' && field.link && contact[field.name]"
               class="h-4 w-4 shrink-0 cursor-pointer text-gray-600"
               @click="field.link(contact[field.name])"
             />
diff --git a/frontend/src/pages/Deal.vue b/frontend/src/pages/Deal.vue
index 0209e658..1ec7f83b 100644
--- a/frontend/src/pages/Deal.vue
+++ b/frontend/src/pages/Deal.vue
@@ -272,7 +272,7 @@
                       />
                     </div>
                     <ExternalLinkIcon
-                      v-if="field.type === 'link' && field.link"
+                      v-if="field.type === 'link' && field.link && deal.data[field.name]"
                       class="h-4 w-4 shrink-0 cursor-pointer text-gray-600"
                       @click="field.link(deal.data[field.name])"
                     />
diff --git a/frontend/src/pages/Lead.vue b/frontend/src/pages/Lead.vue
index a17e48a8..f961274f 100644
--- a/frontend/src/pages/Lead.vue
+++ b/frontend/src/pages/Lead.vue
@@ -129,7 +129,7 @@
       <div class="flex flex-1 flex-col justify-between overflow-hidden">
         <div class="flex flex-col overflow-y-auto">
           <div
-            v-for="(section, i) in detailSections"
+            v-for="section in detailSections"
             :key="section.label"
             class="flex flex-col"
           >
@@ -282,7 +282,7 @@
                       />
                     </div>
                     <ExternalLinkIcon
-                      v-if="field.type === 'link' && field.link"
+                      v-if="field.type === 'link' && field.link && lead.data[field.name]"
                       class="h-4 w-4 shrink-0 cursor-pointer text-gray-600"
                       @click="field.link(lead.data[field.name])"
                     />