fix: handle script load while setting up script

This commit is contained in:
Shariq Ansari 2025-05-26 17:50:24 +05:30
parent 875431a620
commit 91f7cf05fc
2 changed files with 47 additions and 13 deletions

View File

@ -14,7 +14,7 @@ export function useDocument(doctype, docname) {
documentsCache[doctype][docname] = createDocumentResource({
doctype: doctype,
name: docname,
onSuccess: () => setupFormScript(),
onSuccess: async () => await setupFormScript(),
setValue: {
onSuccess: () => {
toast.success(__('Document updated successfully'))
@ -27,23 +27,49 @@ export function useDocument(doctype, docname) {
})
}
function setupFormScript() {
if (controllersCache[doctype]?.[docname]) return
async function setupFormScript() {
if (
controllersCache[doctype] &&
typeof controllersCache[doctype][docname] === 'object'
) {
return
}
if (!controllersCache[doctype]) {
controllersCache[doctype] = {}
}
controllersCache[doctype][docname] = setupScript(
documentsCache[doctype][docname],
)
controllersCache[doctype][docname] = {}
const controllersArray = await setupScript(documentsCache[doctype][docname])
if (!controllersArray || controllersArray.length === 0) return
const organizedControllers = {}
for (const controller of controllersArray) {
const controllerKey = controller.constructor.name // e.g., "CRMLead", "CRMProducts"
if (!organizedControllers[controllerKey]) {
organizedControllers[controllerKey] = []
}
organizedControllers[controllerKey].push(controller)
}
controllersCache[doctype][docname] = organizedControllers
}
function getControllers(row = null) {
const _doctype = row?.doctype || doctype
return (controllersCache[doctype]?.[docname] || []).filter(
(c) => c.constructor.name === _doctype.replace(/\s+/g, ''),
)
const controllerKey = _doctype.replace(/\s+/g, '')
const docControllers = controllersCache[doctype]?.[docname]
if (
typeof docControllers === 'object' &&
docControllers !== null &&
!Array.isArray(docControllers)
) {
return docControllers[controllerKey] || []
}
return []
}
async function triggerOnRefresh() {

View File

@ -20,15 +20,23 @@ export function getScript(doctype, view = 'Form') {
doctypeScripts[doctype][script.name] = script || {}
}
},
onError: (err) => {
console.error(
`Error loading CRM Form Scripts for ${doctype} (view: ${view}):`,
err,
)
},
})
if (!doctypeScripts[doctype] && !scripts.loading) {
scripts.fetch()
}
function setupScript(document, helpers = {}) {
let scripts = doctypeScripts[doctype]
if (!scripts) return null
async function setupScript(document, helpers = {}) {
await scripts.promise
let scriptDefs = doctypeScripts[doctype]
if (!scriptDefs || Object.keys(scriptDefs).length === 0) return null
const { $dialog, $socket, makeCall } = globalStore()
@ -42,7 +50,7 @@ export function getScript(doctype, view = 'Form') {
makePhoneCall: makeCall,
}
return setupMultipleFormControllers(scripts, document, helpers)
return setupMultipleFormControllers(scriptDefs, document, helpers)
}
function setupMultipleFormControllers(scriptStrings, document, helpers) {