From 8cb0b9aec084f7368eff55a5fce7eb605074f029 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Mon, 3 Jun 2024 18:52:27 +0530 Subject: [PATCH] fix: use lodash to compare objs --- frappe-ui | 2 +- frontend/package.json | 1 + frontend/src/components/ViewControls.vue | 3 ++- yarn.lock | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/frappe-ui b/frappe-ui index 6fd62697..d7ad7bd0 160000 --- a/frappe-ui +++ b/frappe-ui @@ -1 +1 @@ -Subproject commit 6fd62697e6f35f1fbf1daa12a6573dc0a73a02b0 +Subproject commit d7ad7bd0d09f25a446da984e6006479ea218acd0 diff --git a/frontend/package.json b/frontend/package.json index 89251475..e23079c0 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -15,6 +15,7 @@ "feather-icons": "^4.28.0", "frappe-ui": "^0.1.59", "gemoji": "^8.1.0", + "lodash": "^4.17.21", "mime": "^4.0.1", "pinia": "^2.0.33", "socket.io-client": "^4.7.2", diff --git a/frontend/src/components/ViewControls.vue b/frontend/src/components/ViewControls.vue index 53bae21d..fb7b46fc 100644 --- a/frontend/src/components/ViewControls.vue +++ b/frontend/src/components/ViewControls.vue @@ -268,6 +268,7 @@ import { computed, ref, onMounted, watch, h, markRaw } from 'vue' import { useRouter, useRoute } from 'vue-router' import { useDebounceFn } from '@vueuse/core' import { isMobileView } from '@/stores/settings' +import _ from 'lodash' const props = defineProps({ doctype: { @@ -940,7 +941,7 @@ defineExpose({ applyFilter, applyLikeFilter, likeDoc }) watch( () => getView(route.query.view, route.params.viewType, props.doctype), (value, old_value) => { - if (JSON.stringify(value) === JSON.stringify(old_value)) return + if (_.isEqual(value, old_value)) return reload() }, { deep: true } diff --git a/yarn.lock b/yarn.lock index 041c3b84..9d274e51 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4053,7 +4053,7 @@ lodash.sortby@^4.7.0: resolved "https://registry.yarnpkg.com/lodash.sortby/-/lodash.sortby-4.7.0.tgz#edd14c824e2cc9c1e0b0a1b42bb5210516a42438" integrity sha512-HDWXG8isMntAyRF5vZ7xKuEvOhT4AhlRt/3czTSjvGUxjYCBVRQY48ViDHyfYz9VIoBkW4TMGQNapx+l3RUwdA== -lodash@^4.17.20: +lodash@^4.17.20, lodash@^4.17.21: version "4.17.21" resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c" integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==