test/crm
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: replace json.loads with frappe.parse_json for assignees in remove_assignments function

Browse Source 
(cherry picked from commit 5010cccc7158dca670530c564a4a4b01067e090f)
This commit is contained in:
Shariq Ansari 2025-08-01 13:03:14 +05:30 committed by Mergify
parent 7e53e0f4e4
commit 8c3733a212
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crm/api/doc.py
View File

@ -662,7 +662,7 @@ def get_fields_meta(doctype, restricted_fieldtypes=None, as_array=False, only_re
@frappe.whitelist() @frappe.whitelist()
def remove_assignments(doctype, name, assignees, ignore_permissions=False): def remove_assignments(doctype, name, assignees, ignore_permissions=False):
assignees = json.loads(assignees) assignees = frappe.parse_json(assignees)
if not assignees: if not assignees:
return return

9
frontend/src/components/AssignToBody.vue
View File

@ -99,7 +99,6 @@ const oldAssignees = ref([])
const assignToMe = ref(false) const assignToMe = ref(false)
const error = ref('') const error = ref('')
const ownerRemoved = ref(false)
const { users, getUser } = usersStore() const { users, getUser } = usersStore()
@ -143,7 +142,6 @@ watch(assignToMe, (val) => {
watch( watch(
() => props.open, () => props.open,
(val) => { (val) => {
ownerRemoved.value = false
if (val) { if (val) {
oldAssignees.value = [...(assignees.value || [])] oldAssignees.value = [...(assignees.value || [])]
@ -170,15 +168,10 @@ async function updateAssignees() {
.map((assignee) => assignee.name) .map((assignee) => assignee.name)
if (removedAssignees.length) { if (removedAssignees.length) {
if (!ownerRemoved.value && removedAssignees.includes(owner.value)) {
ownerRemoved.value = true
return
}
await call('crm.api.doc.remove_assignments', { await call('crm.api.doc.remove_assignments', {
doctype: props.doctype, doctype: props.doctype,
name: props.doc.name, name: props.doc.name,
assignees: JSON.stringify(removedAssignees), assignees: removedAssignees,
}) })
toast.success(__('Assignees removed successfully.')) toast.success(__('Assignees removed successfully.'))
} }