From 8c25aaea4a889d71380fe1f118a1c174dc6c7cda Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Wed, 12 Jun 2024 14:32:13 +0530
Subject: [PATCH] refactor: created common settingspage component

---
 .../src/components/Settings/SettingsPage.vue  | 79 +++++++++++++++++++
 .../components/Settings/TwilioSettings.vue    | 63 +--------------
 .../components/Settings/WhatsAppSettings.vue  | 72 +----------------
 3 files changed, 84 insertions(+), 130 deletions(-)
 create mode 100644 frontend/src/components/Settings/SettingsPage.vue

diff --git a/frontend/src/components/Settings/SettingsPage.vue b/frontend/src/components/Settings/SettingsPage.vue
new file mode 100644
index 00000000..affc16ed
--- /dev/null
+++ b/frontend/src/components/Settings/SettingsPage.vue
@@ -0,0 +1,79 @@
+<template>
+  <div class="flex h-full flex-col gap-8">
+    <h2 class="text-xl font-semibold leading-none">
+      {{ __(doctype) }}
+    </h2>
+    <div class="flex-1 overflow-y-auto">
+      <Fields
+        v-if="data?.doc && sections"
+        :sections="sections"
+        :data="data.doc"
+      />
+    </div>
+    <div class="flex flex-row-reverse">
+      <Button :label="__('Update')" variant="solid" />
+    </div>
+  </div>
+</template>
+<script setup>
+import Fields from '@/components/Fields.vue'
+import { createDocumentResource, createResource } from 'frappe-ui'
+import { computed } from 'vue'
+
+const props = defineProps({
+  doctype: {
+    type: String,
+    required: true,
+  },
+})
+
+const fields = createResource({
+  url: 'crm.api.doc.get_fields',
+  cache: ['fields', props.doctype],
+  params: {
+    doctype: props.doctype,
+    allow_all_fieldtypes: true,
+  },
+  auto: true,
+})
+
+const data = createDocumentResource({
+  doctype: props.doctype,
+  name: props.doctype,
+  fields: ['*'],
+  cache: props.doctype,
+  auto: true,
+})
+
+const sections = computed(() => {
+  if (!fields.data) return []
+  let _sections = []
+  let fieldsData = fields.data
+
+  if (fieldsData[0].type !== 'Section Break') {
+    _sections.push({
+      label: 'General',
+      columns: 1,
+      fields: [],
+    })
+  }
+  fieldsData.forEach((field) => {
+    if (field.type === 'Section Break') {
+      _sections.push({
+        label: field.value,
+        columns: 1,
+        fields: [],
+      })
+    } else if (field.type === 'Column Break') {
+      _sections[_sections.length - 1].columns += 1
+    } else {
+      _sections[_sections.length - 1].fields.push({
+        ...field,
+        name: field.value,
+      })
+    }
+  })
+
+  return _sections
+})
+</script>
diff --git a/frontend/src/components/Settings/TwilioSettings.vue b/frontend/src/components/Settings/TwilioSettings.vue
index 2842d1bf..5672da6f 100644
--- a/frontend/src/components/Settings/TwilioSettings.vue
+++ b/frontend/src/components/Settings/TwilioSettings.vue
@@ -1,65 +1,6 @@
 <template>
-  <div class="flex flex-col gap-8 h-full">
-    <h2 class="text-xl font-semibold leading-none">
-      {{ __('Twilio Settings') }}
-    </h2>
-    <div class="flex-1 overflow-y-auto">
-      <Fields
-        v-if="data?.doc && sections"
-        :sections="sections"
-        :data="data.doc"
-      />
-    </div>
-    <div class="flex flex-row-reverse">
-      <Button :label="__('Update')" variant="solid" />
-    </div>
-  </div>
+  <SettingsPage doctype="Twilio Settings" />
 </template>
 <script setup>
-import Fields from '@/components/Fields.vue'
-import { createDocumentResource, createResource } from 'frappe-ui'
-import { computed } from 'vue'
-
-const fields = createResource({
-  url: 'crm.api.doc.get_fields',
-  cache: ['fields', 'Twilio Settings'],
-  params: {
-    doctype: 'Twilio Settings',
-    allow_all_fieldtypes: true,
-  },
-  auto: true,
-})
-
-const data = createDocumentResource({
-  doctype: 'Twilio Settings',
-  name: 'Twilio Settings',
-  fields: ['*'],
-  cache: 'Twilio Settings',
-  auto: true,
-})
-
-const sections = computed(() => {
-  if (!fields.data) return []
-  let _sections = []
-  let fieldsData = fields.data
-
-  fieldsData.forEach((field) => {
-    if (field.type === 'Section Break') {
-      _sections.push({
-        label: field.value,
-        columns: 1,
-        fields: [],
-      })
-    } else if (field.type === 'Column Break') {
-      _sections[_sections.length - 1].columns += 1
-    } else {
-      _sections[_sections.length - 1].fields.push({
-        ...field,
-        name: field.value,
-      })
-    }
-  })
-
-  return _sections
-})
+import SettingsPage from '@/components/Settings/SettingsPage.vue'
 </script>
diff --git a/frontend/src/components/Settings/WhatsAppSettings.vue b/frontend/src/components/Settings/WhatsAppSettings.vue
index 6023a2b7..027b1b91 100644
--- a/frontend/src/components/Settings/WhatsAppSettings.vue
+++ b/frontend/src/components/Settings/WhatsAppSettings.vue
@@ -1,72 +1,6 @@
 <template>
-  <div class="flex h-full flex-col gap-8">
-    <h2 class="text-xl font-semibold leading-none">
-      {{ __('WhatsApp Settings') }}
-    </h2>
-    <div class="flex-1 overflow-y-auto">
-      <Fields
-        v-if="data?.doc && sections"
-        :sections="sections"
-        :data="data.doc"
-      />
-    </div>
-    <div class="flex flex-row-reverse">
-      <Button :label="__('Update')" variant="solid" />
-    </div>
-  </div>
+  <SettingsPage doctype="WhatsApp Settings" />
 </template>
 <script setup>
-import Fields from '@/components/Fields.vue'
-import { createDocumentResource, createResource } from 'frappe-ui'
-import { computed } from 'vue'
-
-const fields = createResource({
-  url: 'crm.api.doc.get_fields',
-  cache: ['fields', 'WhatsApp Settings'],
-  params: {
-    doctype: 'WhatsApp Settings',
-    includeAllFields: true,
-  },
-  auto: true,
-})
-
-const data = createDocumentResource({
-  doctype: 'WhatsApp Settings',
-  name: 'WhatsApp Settings',
-  fields: ['*'],
-  cache: 'WhatsApp Settings',
-  auto: true,
-})
-
-const sections = computed(() => {
-  if (!fields.data) return []
-  let _sections = []
-  let fieldsData = fields.data
-
-  if (fieldsData[0].type !== 'Section Break') {
-    _sections.push({
-      label: 'General',
-      columns: 1,
-      fields: [],
-    })
-  }
-  fieldsData.forEach((field) => {
-    if (field.type === 'Section Break') {
-      _sections.push({
-        label: field.value,
-        columns: 1,
-        fields: [],
-      })
-    } else if (field.type === 'Column Break') {
-      _sections[_sections.length - 1].columns += 1
-    } else {
-      _sections[_sections.length - 1].fields.push({
-        ...field,
-        name: field.value,
-      })
-    }
-  })
-
-  return _sections
-})
-</script>
+import SettingsPage from '@/components/Settings/SettingsPage.vue'
+</script>
\ No newline at end of file