From 7bf7d94127ae9238fc6729460a5db6782d777938 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Thu, 1 May 2025 18:25:25 +0530
Subject: [PATCH] fix: added fieldChange method in almost all fieldtypes

---
 frontend/src/components/FieldLayout/Field.vue | 27 +++++++-----
 frontend/src/components/SidePanelLayout.vue   | 44 +++++--------------
 2 files changed, 27 insertions(+), 44 deletions(-)

diff --git a/frontend/src/components/FieldLayout/Field.vue b/frontend/src/components/FieldLayout/Field.vue
index 8f956675..eecfeaaa 100644
--- a/frontend/src/components/FieldLayout/Field.vue
+++ b/frontend/src/components/FieldLayout/Field.vue
@@ -43,7 +43,7 @@
         class="form-control"
         type="checkbox"
         v-model="data[field.fieldname]"
-        @change="(e) => (data[field.fieldname] = e.target.checked)"
+        @change="(e) => fieldChange(e.target.checked, field)"
         :disabled="Boolean(field.read_only)"
       />
       <label
@@ -71,7 +71,7 @@
           field.fieldtype == 'Link' ? field.options : data[field.options]
         "
         :filters="field.filters"
-        @change="(v) => (data[field.fieldname] = v)"
+        @change="(v) => fieldChange(v, field)"
         :placeholder="getPlaceholder(field)"
         :onCreate="field.create"
       />
@@ -99,7 +99,7 @@
       :value="data[field.fieldname] && getUser(data[field.fieldname]).full_name"
       :doctype="field.options"
       :filters="field.filters"
-      @change="(v) => (data[field.fieldname] = v)"
+      @change="(v) => fieldChange(v, field)"
       :placeholder="getPlaceholder(field)"
       :hideMe="true"
     >
@@ -124,19 +124,21 @@
     </Link>
     <DateTimePicker
       v-else-if="field.fieldtype === 'Datetime'"
-      v-model="data[field.fieldname]"
+      :value="data[field.fieldname]"
       icon-left=""
       :formatter="(date) => getFormat(date, '', true, true)"
       :placeholder="getPlaceholder(field)"
       input-class="border-none"
+      @change="(v) => fieldChange(v, field)"
     />
     <DatePicker
       v-else-if="field.fieldtype === 'Date'"
       icon-left=""
-      v-model="data[field.fieldname]"
+      :value="data[field.fieldname]"
       :formatter="(date) => getFormat(date, '', true)"
       :placeholder="getPlaceholder(field)"
       input-class="border-none"
+      @change="(v) => fieldChange(v, field)"
     />
     <FormControl
       v-else-if="
@@ -144,13 +146,15 @@
       "
       type="textarea"
       :placeholder="getPlaceholder(field)"
-      v-model="data[field.fieldname]"
+      :value="data[field.fieldname]"
+      @change="fieldChange($event.target.value, field)"
     />
     <FormControl
       v-else-if="['Int'].includes(field.fieldtype)"
       type="number"
       :placeholder="getPlaceholder(field)"
-      v-model="data[field.fieldname]"
+      :value="data[field.fieldname]"
+      @change="fieldChange($event.target.value, field)"
     />
     <FormControl
       v-else-if="field.fieldtype === 'Percent'"
@@ -158,7 +162,7 @@
       :value="getFormattedPercent(field.fieldname, data)"
       :placeholder="getPlaceholder(field)"
       :disabled="Boolean(field.read_only)"
-      @change="data[field.fieldname] = flt($event.target.value)"
+      @change="fieldChange(flt($event.target.value), field)"
     />
     <FormControl
       v-else-if="field.fieldtype === 'Float'"
@@ -166,7 +170,7 @@
       :value="getFormattedFloat(field.fieldname, data)"
       :placeholder="getPlaceholder(field)"
       :disabled="Boolean(field.read_only)"
-      @change="data[field.fieldname] = flt($event.target.value)"
+      @change="fieldChange(flt($event.target.value), field)"
     />
     <FormControl
       v-else-if="field.fieldtype === 'Currency'"
@@ -174,14 +178,15 @@
       :value="getFormattedCurrency(field.fieldname, data)"
       :placeholder="getPlaceholder(field)"
       :disabled="Boolean(field.read_only)"
-      @change="data[field.fieldname] = flt($event.target.value)"
+      @change="fieldChange(flt($event.target.value), field)"
     />
     <FormControl
       v-else
       type="text"
       :placeholder="getPlaceholder(field)"
-      v-model="data[field.fieldname]"
+      :value="data[field.fieldname]"
       :disabled="Boolean(field.read_only)"
+      @change="fieldChange($event.target.value, field)"
     />
   </div>
 </template>
diff --git a/frontend/src/components/SidePanelLayout.vue b/frontend/src/components/SidePanelLayout.vue
index 59abbd69..1d1486a5 100644
--- a/frontend/src/components/SidePanelLayout.vue
+++ b/frontend/src/components/SidePanelLayout.vue
@@ -143,11 +143,7 @@
                           type="checkbox"
                           v-model="document.doc[field.fieldname]"
                           @change.stop="
-                            emit(
-                              'update',
-                              field.fieldname,
-                              $event.target.checked,
-                            )
+                            fieldChange($event.target.checked, field)
                           "
                           :disabled="Boolean(field.read_only)"
                         />
@@ -165,9 +161,7 @@
                           :value="document.doc[field.fieldname]"
                           :placeholder="field.placeholder"
                           :debounce="500"
-                          @change.stop="
-                            emit('update', field.fieldname, $event.target.value)
-                          "
+                          @change.stop="fieldChange($event.target.value, field)"
                         />
                         <FormControl
                           v-else-if="field.fieldtype === 'Select'"
@@ -187,7 +181,7 @@
                           "
                           doctype="User"
                           :filters="field.filters"
-                          @change="(v) => emit('update', field.fieldname, v)"
+                          @change="(v) => fieldChange(v, field)"
                           :placeholder="'Select' + ' ' + field.label + '...'"
                           :hideMe="true"
                         >
@@ -229,7 +223,7 @@
                           "
                           :filters="field.filters"
                           :placeholder="field.placeholder"
-                          @change="(v) => emit('update', field.fieldname, v)"
+                          @change="(v) => fieldChange(v, field)"
                           :onCreate="field.create"
                         />
                         <div
@@ -244,7 +238,7 @@
                             "
                             :placeholder="field.placeholder"
                             placement="left-start"
-                            @change="(v) => emit('update', field.fieldname, v)"
+                            @change="(v) => fieldChange(v, field)"
                           />
                         </div>
                         <div
@@ -257,7 +251,7 @@
                             :formatter="(date) => getFormat(date, '', true)"
                             :placeholder="field.placeholder"
                             placement="left-start"
-                            @change="(v) => emit('update', field.fieldname, v)"
+                            @change="(v) => fieldChange(v, field)"
                           />
                         </div>
                         <FormControl
@@ -270,11 +264,7 @@
                           :placeholder="field.placeholder"
                           :debounce="500"
                           @change.stop="
-                            emit(
-                              'update',
-                              field.fieldname,
-                              flt($event.target.value),
-                            )
+                            fieldChange(flt($event.target.value), field)
                           "
                         />
                         <FormControl
@@ -284,9 +274,7 @@
                           v-model="document.doc[field.fieldname]"
                           :placeholder="field.placeholder"
                           :debounce="500"
-                          @change.stop="
-                            emit('update', field.fieldname, $event.target.value)
-                          "
+                          @change.stop="fieldChange($event.target.value, field)"
                         />
                         <FormControl
                           v-else-if="field.fieldtype === 'Float'"
@@ -298,11 +286,7 @@
                           :placeholder="field.placeholder"
                           :debounce="500"
                           @change.stop="
-                            emit(
-                              'update',
-                              field.fieldname,
-                              flt($event.target.value),
-                            )
+                            fieldChange(flt($event.target.value), field)
                           "
                         />
                         <FormControl
@@ -315,11 +299,7 @@
                           :placeholder="field.placeholder"
                           :debounce="500"
                           @change.stop="
-                            emit(
-                              'update',
-                              field.fieldname,
-                              flt($event.target.value),
-                            )
+                            fieldChange(flt($event.target.value), field)
                           "
                         />
                         <FormControl
@@ -329,9 +309,7 @@
                           :value="document.doc[field.fieldname]"
                           :placeholder="field.placeholder"
                           :debounce="500"
-                          @change.stop="
-                            emit('update', field.fieldname, $event.target.value)
-                          "
+                          @change.stop="fieldChange($event.target.value, field)"
                         />
                       </div>
                       <div class="ml-1">