From 73bb4bd9f80d414a881e0f682f9814c5f151cb71 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Wed, 12 Mar 2025 17:08:42 +0530
Subject: [PATCH] fix: maximize if complete now is clicked

---
 frontend/src/components/Layouts/AppSidebar.vue | 9 +++++++--
 frontend/src/components/Modals/HelpModal.vue   | 2 +-
 frontend/src/composables/onboarding.js         | 4 ----
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/frontend/src/components/Layouts/AppSidebar.vue b/frontend/src/components/Layouts/AppSidebar.vue
index ec9def61..98f5644e 100644
--- a/frontend/src/components/Layouts/AppSidebar.vue
+++ b/frontend/src/components/Layouts/AppSidebar.vue
@@ -77,7 +77,12 @@
       <GettingStartedBanner
         v-if="!isOnboardingStepsCompleted"
         :isSidebarCollapsed="isSidebarCollapsed"
-        @completeNow="showHelpModal = true"
+        @completeNow="
+          () => {
+            minimize = false
+            showHelpModal = true
+          }
+        "
       />
       <SidebarLink
         v-else
@@ -141,7 +146,7 @@ import {
   unreadNotificationsCount,
   notificationsStore,
 } from '@/stores/notifications'
-import { isOnboardingStepsCompleted } from '@/composables/onboarding'
+import { isOnboardingStepsCompleted, minimize } from '@/composables/onboarding'
 import { FeatherIcon, TrialBanner } from 'frappe-ui'
 import { useStorage } from '@vueuse/core'
 import { ref, computed, h } from 'vue'
diff --git a/frontend/src/components/Modals/HelpModal.vue b/frontend/src/components/Modals/HelpModal.vue
index 6c205815..ec4419d1 100644
--- a/frontend/src/components/Modals/HelpModal.vue
+++ b/frontend/src/components/Modals/HelpModal.vue
@@ -52,7 +52,7 @@
                 ? 'text-ink-gray-5 line-through'
                 : 'text-ink-gray-8',
             ]"
-            @click="step.onClick"
+            @click="() => !step.completed && step.onClick()"
           >
             <component :is="step.icon" class="h-4" />
             <div class="text-base">{{ step.title }}</div>
diff --git a/frontend/src/composables/onboarding.js b/frontend/src/composables/onboarding.js
index 63309189..737f5911 100644
--- a/frontend/src/composables/onboarding.js
+++ b/frontend/src/composables/onboarding.js
@@ -29,9 +29,7 @@ const steps = reactive([
     icon: markRaw(LeadsIcon),
     completed: false,
     onClick: () => {
-      if (steps[0].completed) return
       minimize.value = true
-
       router.push({ name: 'Leads' })
     },
   },
@@ -41,9 +39,7 @@ const steps = reactive([
     icon: markRaw(InviteIcon),
     completed: false,
     onClick: () => {
-      if (steps[1].completed) return
       minimize.value = true
-
       showSettings.value = true
       activeSettingsPage.value = 'Invite Members'
     },