From 6973d782f873ebbd429d3025a14aae6995ab9820 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Fri, 28 Feb 2025 16:02:14 +0530 Subject: [PATCH] fix: newQuickFilters getting cleared --- frontend/src/components/ViewControls.vue | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/frontend/src/components/ViewControls.vue b/frontend/src/components/ViewControls.vue index 9d1bf696..494b927a 100644 --- a/frontend/src/components/ViewControls.vue +++ b/frontend/src/components/ViewControls.vue @@ -192,7 +192,7 @@ { label: __('Customize quick filters'), icon: () => h(QuickFilterIcon, { class: 'h-4 w-4' }), - onClick: () => (customizeQuickFilter = true), + onClick: () => showCustomizeQuickFilter(), condition: () => isManager(), }, ], @@ -664,6 +664,11 @@ const { getFields } = getMeta(props.doctype) const customizeQuickFilter = ref(false) +function showCustomizeQuickFilter() { + customizeQuickFilter.value = true + setupNewQuickFilters(quickFilters.data) +} + const newQuickFilters = ref([]) function addQuickFilter(f) { @@ -772,14 +777,18 @@ const quickFilters = createResource({ cache: ['Quick Filters', props.doctype], auto: true, onSuccess(filters) { - newQuickFilters.value = filters.map((f) => ({ - label: f.label, - fieldname: f.fieldname, - fieldtype: f.fieldtype, - })) + setupNewQuickFilters(filters) }, }) +function setupNewQuickFilters(filters) { + newQuickFilters.value = filters.map((f) => ({ + label: f.label, + fieldname: f.fieldname, + fieldtype: f.fieldtype, + })) +} + function applyQuickFilter(filter, value) { let filters = { ...list.value.params.filters } let field = filter.fieldname