From 5c7f835e4c2d6400302c3466ab0b8c9d655bf274 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Wed, 21 May 2025 15:40:37 +0530 Subject: [PATCH] fix: renamed invite members to invite agent --- frontend/components.d.ts | 2 +- .../src/components/Layouts/AppSidebar.vue | 4 +-- frontend/src/components/Settings/Agents.vue | 31 ++++++++++++------- ...viteMemberPage.vue => InviteAgentPage.vue} | 2 +- frontend/src/components/Settings/Settings.vue | 6 ++-- 5 files changed, 26 insertions(+), 19 deletions(-) rename frontend/src/components/Settings/{InviteMemberPage.vue => InviteAgentPage.vue} (98%) diff --git a/frontend/components.d.ts b/frontend/components.d.ts index 0adece61..0210cb17 100644 --- a/frontend/components.d.ts +++ b/frontend/components.d.ts @@ -136,8 +136,8 @@ declare module 'vue' { InboundCallIcon: typeof import('./src/components/Icons/InboundCallIcon.vue')['default'] InboxIcon: typeof import('./src/components/Icons/InboxIcon.vue')['default'] IndicatorIcon: typeof import('./src/components/Icons/IndicatorIcon.vue')['default'] + InviteAgentPage: typeof import('./src/components/Settings/InviteAgentPage.vue')['default'] InviteIcon: typeof import('./src/components/Icons/InviteIcon.vue')['default'] - InviteMemberPage: typeof import('./src/components/Settings/InviteMemberPage.vue')['default'] KanbanIcon: typeof import('./src/components/Icons/KanbanIcon.vue')['default'] KanbanSettings: typeof import('./src/components/Kanban/KanbanSettings.vue')['default'] KanbanView: typeof import('./src/components/Kanban/KanbanView.vue')['default'] diff --git a/frontend/src/components/Layouts/AppSidebar.vue b/frontend/src/components/Layouts/AppSidebar.vue index f7e87c4f..68e87c82 100644 --- a/frontend/src/components/Layouts/AppSidebar.vue +++ b/frontend/src/components/Layouts/AppSidebar.vue @@ -351,7 +351,7 @@ const steps = reactive([ onClick: () => { minimize.value = true showSettings.value = true - activeSettingsPage.value = 'Invite Members' + activeSettingsPage.value = 'Invite Agent' }, condition: () => isManager(), }, @@ -529,7 +529,7 @@ const articles = ref([ { name: 'profile', title: __('Profile') }, { name: 'custom-branding', title: __('Custom branding') }, { name: 'home-actions', title: __('Home actions') }, - { name: 'invite-members', title: __('Invite members') }, + { name: 'invite-agent', title: __('Invite agent') }, ], }, { diff --git a/frontend/src/components/Settings/Agents.vue b/frontend/src/components/Settings/Agents.vue index 10020803..f4144a1c 100644 --- a/frontend/src/components/Settings/Agents.vue +++ b/frontend/src/components/Settings/Agents.vue @@ -61,7 +61,7 @@ RoleOption({ - role: 'Sales Manager', + role: __('Manager Access'), active: props.active, selected: agentRole === 'Sales Manager', - onClick: () => updateRole(user.name, 'Sales Manager'), + onClick: () => updateRole(agent, 'Sales Manager'), }), }, { - label: 'Sales Agent', + label: __('Regular Access'), component: (props) => RoleOption({ - role: 'Sales Agent', + role: __('Regular Access'), active: props.active, selected: agentRole === 'Sales User', - onClick: () => updateRole(user.name, 'Sales User'), + onClick: () => updateRole(agent, 'Sales User'), }), }, ] @@ -151,14 +156,16 @@ function RoleOption({ active, role, onClick, selected }) { } function updateRole(agent, newRole) { - const currentRole = getUserRole(agent) + const currentRole = getUserRole(agent.name) if (currentRole === newRole) return call('crm.fcrm.doctype.crm_agent.crm_agent.update_agent_role', { - user: agent, + user: agent.name, new_role: newRole, }).then(() => { - toast.success(__('{0} role updated to {1}', [agent, newRole])) + toast.success( + __('{0} has been granted {1}', [agent.agent_name, roleMap[newRole]]), + ) users.reload() agents.reload() }) diff --git a/frontend/src/components/Settings/InviteMemberPage.vue b/frontend/src/components/Settings/InviteAgentPage.vue similarity index 98% rename from frontend/src/components/Settings/InviteMemberPage.vue rename to frontend/src/components/Settings/InviteAgentPage.vue index 3f0cac8d..1b2f193b 100644 --- a/frontend/src/components/Settings/InviteMemberPage.vue +++ b/frontend/src/components/Settings/InviteAgentPage.vue @@ -109,7 +109,7 @@ const error = ref(null) const description = computed(() => { return { 'Sales Manager': - 'Can manage and invite new members, and create public & private views (reports).', + 'Can manage and invite new agents, and create public & private views (reports).', 'Sales User': 'Can work with leads and deals and create private views (reports).', }[role.value] diff --git a/frontend/src/components/Settings/Settings.vue b/frontend/src/components/Settings/Settings.vue index dfac14fa..03a51fa0 100644 --- a/frontend/src/components/Settings/Settings.vue +++ b/frontend/src/components/Settings/Settings.vue @@ -48,7 +48,7 @@ import InviteIcon from '@/components/Icons/InviteIcon.vue' import Email2Icon from '@/components/Icons/Email2Icon.vue' import Agents from '@/components/Settings/Agents.vue' import GeneralSettings from '@/components/Settings/GeneralSettings.vue' -import InviteMemberPage from '@/components/Settings/InviteMemberPage.vue' +import InviteAgentPage from '@/components/Settings/InviteAgentPage.vue' import ProfileSettings from '@/components/Settings/ProfileSettings.vue' import WhatsAppSettings from '@/components/Settings/WhatsAppSettings.vue' import ERPNextSettings from '@/components/Settings/ERPNextSettings.vue' @@ -96,9 +96,9 @@ const tabs = computed(() => { condition: () => isManager(), }, { - label: __('Invite Members'), + label: __('Invite Agent'), icon: InviteIcon, - component: markRaw(InviteMemberPage), + component: markRaw(InviteAgentPage), condition: () => isManager(), }, {