From 571126c36d54ed301ce762ad57dd3465dec27787 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Wed, 4 Jun 2025 18:34:19 +0530 Subject: [PATCH] fix: moved modal related code to modal.js --- frontend/src/components/Modals/GlobalModals.vue | 2 +- frontend/src/components/UserDropdown.vue | 7 ++----- frontend/src/composables/modals.js | 3 +++ frontend/src/composables/settings.js | 2 -- 4 files changed, 6 insertions(+), 8 deletions(-) create mode 100644 frontend/src/composables/modals.js diff --git a/frontend/src/components/Modals/GlobalModals.vue b/frontend/src/components/Modals/GlobalModals.vue index d108e81f..79facc48 100644 --- a/frontend/src/components/Modals/GlobalModals.vue +++ b/frontend/src/components/Modals/GlobalModals.vue @@ -24,7 +24,7 @@ import { createDocumentData, createDocumentCallback, } from '@/composables/document' -import { showAboutModal } from '@/composables/settings' +import { showAboutModal } from '@/composables/modals' import { ref } from 'vue' const showQuickEntryModal = ref(false) diff --git a/frontend/src/components/UserDropdown.vue b/frontend/src/components/UserDropdown.vue index 5397b137..e59f319c 100644 --- a/frontend/src/components/UserDropdown.vue +++ b/frontend/src/components/UserDropdown.vue @@ -55,11 +55,8 @@ import Apps from '@/components/Apps.vue' import { sessionStore } from '@/stores/session' import { usersStore } from '@/stores/users' import { getSettings } from '@/stores/settings' -import { - showSettings, - isMobileView, - showAboutModal, -} from '@/composables/settings' +import { showSettings, isMobileView } from '@/composables/settings' +import { showAboutModal } from '@/composables/modals' import { confirmLoginToFrappeCloud } from '@/composables/frappecloud' import { Dropdown } from 'frappe-ui' import { theme, toggleTheme } from '@/stores/theme' diff --git a/frontend/src/composables/modals.js b/frontend/src/composables/modals.js new file mode 100644 index 00000000..446c0485 --- /dev/null +++ b/frontend/src/composables/modals.js @@ -0,0 +1,3 @@ +import { ref } from 'vue'; + +export const showAboutModal = ref(false); \ No newline at end of file diff --git a/frontend/src/composables/settings.js b/frontend/src/composables/settings.js index 62b16f49..b729bff9 100644 --- a/frontend/src/composables/settings.js +++ b/frontend/src/composables/settings.js @@ -42,5 +42,3 @@ export const isMobileView = computed(() => window.innerWidth < 768) export const showSettings = ref(false) export const activeSettingsPage = ref('') - -export const showAboutModal = ref(false)