From 4ebd56b417e6c002eee312fc3dcad82f4b76e570 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Thu, 18 Jan 2024 17:27:52 +0530
Subject: [PATCH] fix: show error if no email,phone or website set

---
 frontend/src/pages/Deal.vue | 25 +++++++++++++++++++++----
 frontend/src/pages/Lead.vue | 25 +++++++++++++++++++++----
 frontend/src/utils/index.js | 11 ++++++++++-
 3 files changed, 52 insertions(+), 9 deletions(-)

diff --git a/frontend/src/pages/Deal.vue b/frontend/src/pages/Deal.vue
index 53d44cf8..65d6ddd5 100644
--- a/frontend/src/pages/Deal.vue
+++ b/frontend/src/pages/Deal.vue
@@ -72,19 +72,35 @@
             <Tooltip text="Make a call...">
               <Button
                 class="h-7 w-7"
-                @click="() => makeCall(deal.data.mobile_no)"
+                @click="
+                  () =>
+                    deal.data.mobile_no
+                      ? makeCall(deal.data.mobile_no)
+                      : errorMessage('No mobile number set')
+                "
               >
                 <PhoneIcon class="h-4 w-4" />
               </Button>
             </Tooltip>
             <Button class="h-7 w-7">
-              <EmailIcon class="h-4 w-4" @click="openEmailBox()" />
+              <EmailIcon
+                class="h-4 w-4"
+                @click="
+                  deal.data.email
+                    ? openEmailBox()
+                    : errorMessage('No email set')
+                "
+              />
             </Button>
-            <Tooltip v-if="deal.data.website" text="Go to website...">
+            <Tooltip text="Go to website...">
               <Button class="h-7 w-7">
                 <LinkIcon
                   class="h-4 w-4"
-                  @click="deal.data.website && openWebsite(deal.data.website)"
+                  @click="
+                    deal.data.website
+                      ? openWebsite(deal.data.website)
+                      : errorMessage('No website set')
+                  "
                 />
               </Button>
             </Tooltip>
@@ -294,6 +310,7 @@ import {
   createToast,
   setupAssignees,
   setupCustomActions,
+  errorMessage,
 } from '@/utils'
 import { globalStore } from '@/stores/global'
 import { contactsStore } from '@/stores/contacts'
diff --git a/frontend/src/pages/Lead.vue b/frontend/src/pages/Lead.vue
index e68fcc28..33f34b3a 100644
--- a/frontend/src/pages/Lead.vue
+++ b/frontend/src/pages/Lead.vue
@@ -113,19 +113,35 @@
                 <Tooltip text="Make a call...">
                   <Button
                     class="h-7 w-7"
-                    @click="() => makeCall(lead.data.mobile_no)"
+                    @click="
+                      () =>
+                        lead.data.mobile_no
+                          ? makeCall(lead.data.mobile_no)
+                          : errorMessage('No phone number set')
+                    "
                   >
                     <PhoneIcon class="h-4 w-4" />
                   </Button>
                 </Tooltip>
                 <Button class="h-7 w-7">
-                  <EmailIcon class="h-4 w-4" @click="openEmailBox()" />
+                  <EmailIcon
+                    class="h-4 w-4"
+                    @click="
+                      lead.data.email
+                        ? openEmailBox()
+                        : errorMessage('No email set')
+                    "
+                  />
                 </Button>
-                <Tooltip v-if="lead.data.website" text="Go to website...">
+                <Tooltip text="Go to website...">
                   <Button class="h-7 w-7">
                     <LinkIcon
                       class="h-4 w-4"
-                      @click="openWebsite(lead.data.website)"
+                      @click="
+                        lead.data.website
+                          ? openWebsite(lead.data.website)
+                          : errorMessage('No website set')
+                      "
                     />
                   </Button>
                 </Tooltip>
@@ -257,6 +273,7 @@ import {
   createToast,
   setupAssignees,
   setupCustomActions,
+  errorMessage,
 } from '@/utils'
 import { globalStore } from '@/stores/global'
 import { contactsStore } from '@/stores/contacts'
diff --git a/frontend/src/utils/index.js b/frontend/src/utils/index.js
index 3477004b..fd17796f 100644
--- a/frontend/src/utils/index.js
+++ b/frontend/src/utils/index.js
@@ -129,4 +129,13 @@ export function setupCustomActions(data, obj) {
   let script = new Function(data._form_script + '\nreturn setupForm')()
   let formScript = script(obj)
   data._customActions = formScript?.actions || []
-}
\ No newline at end of file
+}
+
+export function errorMessage(title, message) {
+  createToast({
+    title: title || 'Error',
+    text: message,
+    icon: 'x',
+    iconClasses: 'text-red-600',
+  })
+}