From 497ee46f33a5f8d77e86bc13473c8c23a47612d5 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Thu, 17 Oct 2024 17:41:55 +0530
Subject: [PATCH] fix: after attaching change tab to attachments

---
 frontend/src/components/Activities/Activities.vue | 14 +++++++++++++-
 frontend/src/composables/useActiveTabManager.js   |  8 +++++++-
 frontend/src/pages/Deal.vue                       |  7 ++++++-
 frontend/src/pages/Lead.vue                       |  9 +++++++--
 4 files changed, 33 insertions(+), 5 deletions(-)

diff --git a/frontend/src/components/Activities/Activities.vue b/frontend/src/components/Activities/Activities.vue
index 3fe1569a..18ae007c 100644
--- a/frontend/src/components/Activities/Activities.vue
+++ b/frontend/src/components/Activities/Activities.vue
@@ -443,7 +443,12 @@
     v-model="showFilesUploader"
     :doctype="doctype"
     :docname="doc.data.name"
-    @after="() => all_activities.reload()"
+    @after="
+      () => {
+        all_activities.reload()
+        changeTabTo('attachments')
+      }
+    "
   />
 </template>
 <script setup>
@@ -532,6 +537,13 @@ const showFilesUploader = ref(false)
 
 const title = computed(() => props.tabs?.[tabIndex.value]?.name || 'Activity')
 
+const changeTabTo = (tabName) => {
+  const tabNames = props.tabs?.map((tab) => tab.name?.toLowerCase())
+  const index = tabNames?.indexOf(tabName)
+  if (index == -1) return
+  tabIndex.value = index
+}
+
 const all_activities = createResource({
   url: 'crm.api.activities.get_activities',
   params: { name: doc.value.data.name },
diff --git a/frontend/src/composables/useActiveTabManager.js b/frontend/src/composables/useActiveTabManager.js
index 66189c47..ea9afe61 100644
--- a/frontend/src/composables/useActiveTabManager.js
+++ b/frontend/src/composables/useActiveTabManager.js
@@ -7,6 +7,12 @@ export function useActiveTabManager(tabs, storageKey) {
   const route = useRoute()
   const router = useRouter()
 
+  const changeTabTo = (tabName) => {
+    let index = findTabIndex(tabName)
+    if (index == -1) return
+    tabIndex.value = index
+  }
+
   const preserveLastVisitedTab = useDebounceFn((tabName) => {
     activeTab.value = tabName.toLowerCase()
   }, 300)
@@ -78,5 +84,5 @@ export function useActiveTabManager(tabs, storageKey) {
     tabIndex.value = getActiveTab()
   })
 
-  return { tabIndex }
+  return { tabIndex, changeTabTo }
 }
diff --git a/frontend/src/pages/Deal.vue b/frontend/src/pages/Deal.vue
index 93ae84e3..11696391 100644
--- a/frontend/src/pages/Deal.vue
+++ b/frontend/src/pages/Deal.vue
@@ -309,7 +309,12 @@
     v-model="showFilesUploader"
     doctype="CRM Deal"
     :docname="deal.data.name"
-    @after="() => activities?.all_activities?.reload()"
+    @after="
+      () => {
+        activities?.all_activities?.reload()
+        changeTabTo('attachments')
+      }
+    "
   />
 </template>
 <script setup>
diff --git a/frontend/src/pages/Lead.vue b/frontend/src/pages/Lead.vue
index 61a7bb0a..57918033 100644
--- a/frontend/src/pages/Lead.vue
+++ b/frontend/src/pages/Lead.vue
@@ -282,7 +282,12 @@
     v-model="showFilesUploader"
     doctype="CRM Lead"
     :docname="lead.data.name"
-    @after="() => activities?.all_activities?.reload()"
+    @after="
+      () => {
+        activities?.all_activities?.reload()
+        changeTabTo('attachments')
+      }
+    "
   />
 </template>
 <script setup>
@@ -526,7 +531,7 @@ const tabs = computed(() => {
   return tabOptions.filter((tab) => (tab.condition ? tab.condition() : true))
 })
 
-const { tabIndex } = useActiveTabManager(tabs, 'lastLeadTab')
+const { tabIndex, changeTabTo } = useActiveTabManager(tabs, 'lastLeadTab')
 
 watch(tabs, (value) => {
   if (value && route.params.tabName) {