From 3f85c567465dcc7e169b659e18e1b597e70a8dfa Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Mon, 16 Sep 2024 21:14:40 +0530
Subject: [PATCH] fix: render async list custom actions & bulk actions

---
 frontend/src/components/ListBulkActions.vue | 15 ++++++-----
 frontend/src/utils/index.js                 | 28 ++++++++++-----------
 2 files changed, 22 insertions(+), 21 deletions(-)

diff --git a/frontend/src/components/ListBulkActions.vue b/frontend/src/components/ListBulkActions.vue
index e37b36c9..7a5c969f 100644
--- a/frontend/src/components/ListBulkActions.vue
+++ b/frontend/src/components/ListBulkActions.vue
@@ -19,7 +19,7 @@
 <script setup>
 import EditValueModal from '@/components/Modals/EditValueModal.vue'
 import AssignmentModal from '@/components/Modals/AssignmentModal.vue'
-import { setupListActions, createToast } from '@/utils'
+import { setupListCustomizations, createToast } from '@/utils'
 import { globalStore } from '@/stores/global'
 import { capture } from '@/telemetry'
 import { call } from 'frappe-ui'
@@ -45,7 +45,7 @@ const list = defineModel()
 
 const router = useRouter()
 
-const { $dialog } = globalStore()
+const { $dialog, $socket } = globalStore()
 
 const showEditModal = ref(false)
 const selectedValues = ref([])
@@ -230,17 +230,20 @@ function reload(unselectAll) {
   list.value?.reload()
 }
 
-onMounted(() => {
+onMounted(async () => {
   if (!list.value?.data) return
-  setupListActions(list.value.data, {
+  let customization = await setupListCustomizations(list.value.data, {
     list: list.value,
     call,
     createToast,
     $dialog,
+    $socket,
     router,
   })
-  customBulkActions.value = list.value?.data?.bulkActions || []
-  customListActions.value = list.value?.data?.listActions || []
+  customBulkActions.value =
+    customization?.bulkActions || list.value?.data?.bulkActions || []
+  customListActions.value =
+    customization?.actions || list.value?.data?.listActions || []
 })
 
 defineExpose({
diff --git a/frontend/src/utils/index.js b/frontend/src/utils/index.js
index 87e5d920..ce554505 100644
--- a/frontend/src/utils/index.js
+++ b/frontend/src/utils/index.js
@@ -153,35 +153,33 @@ export async function setupCustomizations(data, obj) {
   return { statuses, actions }
 }
 
-function getActionsFromListScript(script, obj) {
+async function getListScript(script, obj) {
   let scriptFn = new Function(script + '\nreturn setupList')()
-  let listScript = scriptFn(obj)
-  return {
-    actions: listScript?.actions || [],
-    bulk_actions: listScript?.bulk_actions || [],
-  }
+  let listScript = await scriptFn(obj)
+  return listScript || {}
 }
 
-export function setupListActions(data, obj = {}) {
+export async function setupListCustomizations(data, obj = {}) {
   if (!data.list_script) return []
 
   let actions = []
   let bulkActions = []
 
   if (Array.isArray(data.list_script)) {
-    data.list_script.forEach((script) => {
-      let _actions = getActionsFromListScript(script, obj)
-      actions = actions.concat(_actions.actions)
-      bulkActions = bulkActions.concat(_actions.bulk_actions)
-    })
+    for (let script of data.list_script) {
+      let _script = await getListScript(script, obj)
+      actions = actions.concat(_script?.actions || [])
+      bulkActions = bulkActions.concat(_script?.bulk_actions || [])
+    }
   } else {
-    let _actions = getActionsFromListScript(data.list_script, obj)
-    actions = _actions.actions
-    bulkActions = _actions.bulk_actions
+    let _script = await getListScript(data.list_script, obj)
+    actions = _script?.actions || []
+    bulkActions = _script?.bulk_actions || []
   }
 
   data.listActions = actions
   data.bulkActions = bulkActions
+  return { actions, bulkActions }
 }
 
 export function errorMessage(title, message) {