Merge pull request #1188 from frappe/mergify/bp/main-hotfix/pr-1182

fix: do not allow saving public view kanban changes for non managers (backport #1182)

frontend/src/components/ViewControls.vue

@@ -939,9 +939,9 @@ async function updateKanbanSettings(data) {
       value: data.to,
     })
   }
-  let isDirty = viewUpdated.value
 
   viewUpdated.value = true
+
   if (!defaultParams.value) {
     defaultParams.value = getParams()
   }
@@ -969,26 +969,6 @@ async function updateKanbanSettings(data) {
 
   if (!route.query.view) {
     createOrUpdateStandardView()
-  } else if (!data.column_field) {
-    if (isDirty) {
-      $dialog({
-        title: __('Unsaved Changes'),
-        message: __('You have unsaved changes. Do you want to save them?'),
-        variant: 'danger',
-        actions: [
-          {
-            label: __('Update'),
-            variant: 'solid',
-            onClick: (close) => {
-              updateCustomView()
-              close()
-            },
-          },
-        ],
-      })
-    } else {
-      updateCustomView()
-    }
   }
 }
 
@@ -1042,31 +1022,6 @@ function createOrUpdateStandardView() {
   })
 }
 
-function updateCustomView() {
-  viewUpdated.value = false
-  view.value = {
-    doctype: props.doctype,
-    label: view.value.label,
-    type: view.value.type || 'list',
-    icon: view.value.icon,
-    name: view.value.name,
-    filters: defaultParams.value.filters,
-    order_by: defaultParams.value.order_by,
-    group_by_field: defaultParams.value.view.group_by_field,
-    column_field: defaultParams.value.column_field,
-    title_field: defaultParams.value.title_field,
-    kanban_columns: defaultParams.value.kanban_columns,
-    kanban_fields: defaultParams.value.kanban_fields,
-    columns: defaultParams.value.columns,
-    rows: defaultParams.value.rows,
-    route_name: route.name,
-    load_default_columns: view.value.load_default_columns,
-  }
-  call('crm.fcrm.doctype.crm_view_settings.crm_view_settings.update', {
-    view: view.value,
-  }).then(() => reloadView())
-}
-
 function updatePageLength(value, loadMore = false) {
   if (list.value.loading) return
   if (!defaultParams.value) {