From 3752c611576778f028ba78d6c1ae533a88c6040b Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Tue, 16 Sep 2025 17:27:15 +0530
Subject: [PATCH] refactor: update BrandSettings component to improve logo and
 favicon handling

---
 frontend/src/components/Settings/BrandSettings.vue | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/frontend/src/components/Settings/BrandSettings.vue b/frontend/src/components/Settings/BrandSettings.vue
index b5f4ad76..c54c4555 100644
--- a/frontend/src/components/Settings/BrandSettings.vue
+++ b/frontend/src/components/Settings/BrandSettings.vue
@@ -47,7 +47,7 @@
               alt="Logo"
               class="size-8 rounded"
             />
-            <ImageIcon class="size-5 text-ink-gray-4" />
+            <ImageIcon v-else class="size-5 text-ink-gray-4" />
           </div>
           <div class="flex flex-1 flex-col gap-2">
             <span class="text-base font-medium">{{ __('Brand logo') }}</span>
@@ -82,7 +82,7 @@
               alt="Favicon"
               class="size-8 rounded"
             />
-            <ImageIcon class="size-5 text-ink-gray-4" />
+            <ImageIcon v-else class="size-5 text-ink-gray-4" />
           </div>
           <div class="flex flex-1 flex-col gap-2">
             <span class="text-base font-medium">{{ __('Favicon') }}</span>
@@ -105,18 +105,14 @@
         </div>
       </div>
     </div>
-    <div v-if="errorMessage">
-      <ErrorMessage :message="__(errorMessage)" />
-    </div>
   </div>
 </template>
 <script setup>
 import ImageIcon from '~icons/lucide/image'
 import ImageUploader from '@/components/Controls/ImageUploader.vue'
-import { FormControl, ErrorMessage } from 'frappe-ui'
+import { FormControl } from 'frappe-ui'
 import { getSettings } from '@/stores/settings'
 import { showSettings } from '@/composables/settings'
-import { ref } from 'vue'
 
 const { _settings: settings, setupBrand } = getSettings()
 
@@ -128,7 +124,4 @@ function updateSettings() {
     },
   })
 }
-
-const emit = defineEmits(['updateStep'])
-const errorMessage = ref('')
 </script>