refactor: do not update modified field

(cherry picked from commit 3ed2c4812a98f6a08f21276e27d09070987af048)
This commit is contained in:
Shariq Ansari 2025-08-01 16:52:51 +05:30 committed by Mergify
parent 8c3733a212
commit 2bbd0206c6

View File

@ -1,28 +1,19 @@
import frappe import frappe
from frappe import _ from frappe import _
from crm.fcrm.doctype.crm_notification.crm_notification import notify_user from crm.fcrm.doctype.crm_notification.crm_notification import notify_user
def after_insert(doc, method): def after_insert(doc, method):
if ( if doc.reference_type in ["CRM Lead", "CRM Deal"] and doc.reference_name and doc.allocated_to:
doc.reference_type in ["CRM Lead", "CRM Deal"]
and doc.reference_name
and doc.allocated_to
):
fieldname = "lead_owner" if doc.reference_type == "CRM Lead" else "deal_owner" fieldname = "lead_owner" if doc.reference_type == "CRM Lead" else "deal_owner"
lead_owner = frappe.db.get_value( owner = frappe.db.get_value(doc.reference_type, doc.reference_name, fieldname)
doc.reference_type, doc.reference_name, fieldname if not owner:
)
if not lead_owner:
frappe.db.set_value( frappe.db.set_value(
doc.reference_type, doc.reference_name, fieldname, doc.allocated_to doc.reference_type, doc.reference_name, fieldname, doc.allocated_to, update_modified=False
) )
if ( if doc.reference_type in ["CRM Lead", "CRM Deal", "CRM Task"] and doc.reference_name and doc.allocated_to:
doc.reference_type in ["CRM Lead", "CRM Deal", "CRM Task"]
and doc.reference_name
and doc.allocated_to
):
notify_assigned_user(doc) notify_assigned_user(doc)
@ -47,9 +38,7 @@ def notify_assigned_user(doc, is_cancelled=False):
doc.reference_type, doc.reference_name, owner doc.reference_type, doc.reference_name, owner
) )
if is_cancelled if is_cancelled
else _("{0} assigned a {1} {2} to you").format( else _("{0} assigned a {1} {2} to you").format(owner, doc.reference_type, doc.reference_name)
owner, doc.reference_type, doc.reference_name
)
) )
redirect_to_doctype, redirect_to_name = get_redirect_to_doc(doc) redirect_to_doctype, redirect_to_name = get_redirect_to_doc(doc)