From 2b1b21d2e20435a1306f03322d050b286e77cc65 Mon Sep 17 00:00:00 2001
From: Shariq Ansari <sharique.rik@gmail.com>
Date: Tue, 17 Jun 2025 14:39:56 +0530
Subject: [PATCH] fix: show role options based on logged in user's role

---
 frontend/src/components/Settings/Users.vue | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/Settings/Users.vue b/frontend/src/components/Settings/Users.vue
index 684ee726..ec03e140 100644
--- a/frontend/src/components/Settings/Users.vue
+++ b/frontend/src/components/Settings/Users.vue
@@ -130,7 +130,7 @@ import {
 } from 'frappe-ui'
 import { ref, h, watch, onMounted } from 'vue'
 
-const { users: usersResource, getUserRole } = usersStore()
+const { users: usersResource, getUserRole, isAdmin, isManager } = usersStore()
 
 const users = createListResource({
   doctype: 'CRM User',
@@ -170,7 +170,7 @@ function getMoreOptions(user) {
 
 function getDropdownOptions(user) {
   const userRole = getUserRole(user.name)
-  return [
+  let options = [
     {
       label: __('Admin'),
       component: (props) =>
@@ -180,6 +180,7 @@ function getDropdownOptions(user) {
           selected: userRole === 'System Manager',
           onClick: () => updateRole(user, 'System Manager'),
         }),
+      condition: () => isAdmin(),
     },
     {
       label: __('Manager'),
@@ -190,6 +191,7 @@ function getDropdownOptions(user) {
           selected: userRole === 'Sales Manager',
           onClick: () => updateRole(user, 'Sales Manager'),
         }),
+      condition: () => isManager(),
     },
     {
       label: __('Sales User'),
@@ -202,6 +204,8 @@ function getDropdownOptions(user) {
         }),
     },
   ]
+
+  return options.filter((option) => option.condition?.() || true)
 }
 
 function RoleOption({ active, role, onClick, selected }) {