Merge pull request #2142 from hramezani/issue_2123

Add some lint errors to .pylintrc disable list (#2123)

.pylintrc

@@ -21,6 +21,7 @@ disable=
     eval-used,
     fixme,
     import-error,
+    import-outside-toplevel,
     import-self,
     inconsistent-return-statements,
     invalid-name,

gunicorn/http/message.py

@@ -242,7 +242,7 @@ class Request(Message):
                 if idx > limit > 0:
                     raise LimitRequestLine(idx, limit)
                 break
-            elif len(data) - 2 > limit > 0:
+            if len(data) - 2 > limit > 0:
                 raise LimitRequestLine(len(data), limit)
             self.get_data(unreader, buf)
             data = buf.getvalue()

gunicorn/reloader.py

@@ -2,6 +2,7 @@
 #
 # This file is part of gunicorn released under the MIT license.
 # See the NOTICE for more information.
+# pylint: disable=no-else-continue
 
 import os
 import os.path

gunicorn/util.py

@@ -323,7 +323,7 @@ def write_error(sock, status_int, reason, mesg):
 def import_app(module):
     parts = module.split(":", 1)
     if len(parts) == 1:
-        module, obj = module, "application"
+        obj = "application"
     else:
         module, obj = parts[0], parts[1]
 

gunicorn/workers/gthread.py

@@ -9,6 +9,7 @@
 # Keepalive connections are put back in the loop waiting for an event.
 # If no event happen after the keep alive timeout, the connection is
 # closed.
+# pylint: disable=no-else-break
 
 import concurrent.futures as futures
 import errno