jingrow/gunicorn
1
0
Fork 0
mirror of https://github.com/frappe/gunicorn.git synced 2026-01-14 11:09:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

better logging on http parse errors

Browse Source 
NoMoreData now inherits StopIteration and the StopIteration clause in
the workers logs the reason at debug level.
This commit is contained in:
Randall Leeds 2011-11-07 14:56:59 -08:00
parent c6f949b56b
commit b955407003
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gunicorn/http/errors.py
View File

@ -6,7 +6,7 @@
class ParseException(Exception): class ParseException(Exception):
pass pass
class NoMoreData(ParseException): class NoMoreData(ParseException, StopIteration):
def __init__(self, buf=None): def __init__(self, buf=None):
self.buf = buf self.buf = buf
def __str__(self): def __str__(self):

4
gunicorn/workers/async.py
View File

@ -36,8 +36,8 @@ class AsyncWorker(base.Worker):
if not req: if not req:
break break
self.handle_request(req, client, addr) self.handle_request(req, client, addr)
except StopIteration: except StopIteration, e:
pass self.log.debug("Closing connection. %s", e)
except socket.error, e: except socket.error, e:
if e[0] not in (errno.EPIPE, errno.ECONNRESET): if e[0] not in (errno.EPIPE, errno.ECONNRESET):
self.log.exception("Socket error processing request.") self.log.exception("Socket error processing request.")

4
gunicorn/workers/sync.py
View File

@ -69,8 +69,8 @@ class SyncWorker(base.Worker):
parser = http.RequestParser(client) parser = http.RequestParser(client)
req = parser.next() req = parser.next()
self.handle_request(req, client, addr) self.handle_request(req, client, addr)
except StopIteration: except StopIteration, e:
self.log.debug("Ignored premature client disconnection.") self.log.debug("Closing connection. %s", e)
except socket.error, e: except socket.error, e:
if e[0] != errno.EPIPE: if e[0] != errno.EPIPE:
self.log.exception("Error processing request.") self.log.exception("Error processing request.")