jingrow/gunicorn
1
0
Fork 0
mirror of https://github.com/frappe/gunicorn.git synced 2026-01-14 11:09:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

arbiter: Consolidate configuration logging

Browse Source 
Benoit prefers the log prefix for the first line ("Current
configuration:") but not subsequent lines (" {config}: {value}") [1],
so consolidate to a single log.debug call.  The newer '{0}'.format()
syntax requires Python 2.6 [2], but our setup.py only claims
compatibility with 2.6, 2.7, 3.2, and 3.3, so that should be fine.

[1]: https://github.com/benoitc/gunicorn/pull/701/files#r9767234
[2]: http://docs.python.org/2/whatsnew/2.6.html#pep-3101-advanced-string-formatting
This commit is contained in:
W. Trevor King 2014-02-14 15:15:35 -08:00
parent 97977e41ab
commit 64f98a0a1c
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
THANKS
View File

@ -72,3 +72,4 @@ Xie Shi <xieshi@douban.com>
Steven Cummings <estebistec@gmail.com>
Malthe Borch <mborch@gmail.com>
Berker Peksag <berker.peksag@gmail.com>
W. Trevor King <wking@tremily.us>

10
gunicorn/arbiter.py
View File

@ -99,10 +99,12 @@ class Arbiter(object):
self.timeout = self.cfg.timeout
self.proc_name = self.cfg.proc_name
self.log.debug("Current configuration:")
for config, value in sorted(self.cfg.settings.items(),
key=lambda setting: setting[1]):
self.log.debug(" %s: %s", config, value.value)
self.log.debug('Current configuration:\n{0}'.format(
'\n'.join(
' {0}: {1}'.format(config, value.value)
for config, value
in sorted(self.cfg.settings.items(),
key=lambda setting: setting[1]))))
if self.cfg.preload_app:
self.app.wsgi()