From 55e15323acb3e717c4b9a4c46a12838b10bf65ce Mon Sep 17 00:00:00 2001 From: Ryan Peck Date: Wed, 25 Jan 2017 23:01:46 -0500 Subject: [PATCH] Doc tweaks around threads setting In response to #1045 minor tweaks to the documentation to emphasize that the `--threads` setting is only applied to the `gthread` worker. --- docs/source/design.rst | 2 +- docs/source/settings.rst | 3 ++- gunicorn/config.py | 2 ++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/source/design.rst b/docs/source/design.rst index ae5410fd..c521512f 100644 --- a/docs/source/design.rst +++ b/docs/source/design.rst @@ -113,7 +113,7 @@ How Many Threads? =================== Since Gunicorn 19, a threads option can be used to process requests in multiple -threads. Using threads assumes use of the sync worker. One benefit from threads +threads. Using threads assumes use of the gthread worker. One benefit from threads is that requests can take longer than the worker timeout while notifying the master process that it is not frozen and should not be killed. Depending on the system, using multiple threads, multiple worker processes, or some mixture, may diff --git a/docs/source/settings.rst b/docs/source/settings.rst index 4a50f9c5..31f8486e 100644 --- a/docs/source/settings.rst +++ b/docs/source/settings.rst @@ -148,6 +148,8 @@ application's work load. If it is not defined, the default is ``1``. +This setting only affects the Gthread worker type. + .. _worker-connections: worker_connections @@ -1214,4 +1216,3 @@ The variables are passed to the the PasteDeploy entrypoint. Example:: $ gunicorn -b 127.0.0.1:8000 --paste development.ini --paste-global FOO=1 --paste-global BAR=2 .. versionadded:: 19.7 - diff --git a/gunicorn/config.py b/gunicorn/config.py index 442f737c..67ffdd54 100644 --- a/gunicorn/config.py +++ b/gunicorn/config.py @@ -654,6 +654,8 @@ class WorkerThreads(Setting): application's work load. If it is not defined, the default is ``1``. + + This setting only affects the Gthread worker type. """