jingrow/gunicorn
1
0
Fork 0
mirror of https://github.com/frappe/gunicorn.git synced 2026-01-14 11:09:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

pytest: raise on malformed test fixtures

Browse Source 
and unbreak test depending on backslash escape
This commit is contained in:
Paul J. Dorn 2023-12-06 15:30:50 +01:00
parent 26aba9ed9d
commit 559caf9205
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/treq.py
View File

@ -51,7 +51,9 @@ class request(object):
with open(self.fname, 'rb') as handle: with open(self.fname, 'rb') as handle:
self.data = handle.read() self.data = handle.read()
self.data = self.data.replace(b"\n", b"").replace(b"\\r\\n", b"\r\n") self.data = self.data.replace(b"\n", b"").replace(b"\\r\\n", b"\r\n")
self.data = self.data.replace(b"\\0", b"\000") self.data = self.data.replace(b"\\0", b"\000").replace(b"\\n", b"\n").replace(b"\\t", b"\t")
if b"\\" in self.data:
raise AssertionError("Unexpected backslash in test data - only handling HTAB, NUL and CRLF")
# Functions for sending data to the parser. # Functions for sending data to the parser.
# These functions mock out reading from a # These functions mock out reading from a
@ -262,7 +264,8 @@ class request(object):
assert req.trailers == exp.get("trailers", []) assert req.trailers == exp.get("trailers", [])
class badrequest(object): class badrequest:
# FIXME: no good reason why this cannot match what the more extensive mechanism above
def __init__(self, fname): def __init__(self, fname):
self.fname = fname self.fname = fname
self.name = os.path.basename(fname) self.name = os.path.basename(fname)
@ -270,7 +273,9 @@ class badrequest(object):
with open(self.fname) as handle: with open(self.fname) as handle:
self.data = handle.read() self.data = handle.read()
self.data = self.data.replace("\n", "").replace("\\r\\n", "\r\n") self.data = self.data.replace("\n", "").replace("\\r\\n", "\r\n")
self.data = self.data.replace("\\0", "\000") self.data = self.data.replace("\\0", "\000").replace("\\n", "\n").replace("\\t", "\t")
if "\\" in self.data:
raise AssertionError("Unexpected backslash in test data - only handling HTAB, NUL and CRLF")
self.data = self.data.encode('latin1') self.data = self.data.encode('latin1')
def send(self): def send(self):
@ -283,4 +288,6 @@ class badrequest(object):
def check(self, cfg): def check(self, cfg):
p = RequestParser(cfg, self.send(), None) p = RequestParser(cfg, self.send(), None)
next(p) # must fully consume iterator, otherwise EOF errors could go unnoticed
for _ in p:
pass